-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementing the Quantum Matcha Tea backend #86
Open
MatteoRobbiati
wants to merge
45
commits into
main
Choose a base branch
from
matcha
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
773196f
refactor: constructing an abstract QiboTN backend and adapt quimb and…
MatteoRobbiati f1aec1f
feat: abstract qibotn backend
MatteoRobbiati a979d97
feat: drafting qmatchatea backend
MatteoRobbiati 43ebd79
feat: add qmatchatea backend to __init__ backends file
MatteoRobbiati 80bfc7e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 508d5cd
feat: integrating qmatchatea SimulationResult in the circuit execution
MatteoRobbiati 429e15d
feat: integrating qmatchatea SimulationResult in the circuit execution
MatteoRobbiati 85e2e39
feat: improving execute_circuit method by adding a TensorNetworkResul…
MatteoRobbiati 1268888
feat: TensorNetworkResult object implementation
MatteoRobbiati 6fe2c32
fix: removed unused default_runcard dictionary
MatteoRobbiati 91b4b63
refactor: move the imports outside of the backend init
MatteoRobbiati ce40c7b
fix: TensorNetworkResult error raising
MatteoRobbiati 66288ac
feat: add method to compute expectation values from symbolic form of …
MatteoRobbiati dc02764
doc: add example introduction to qmatchatea backend
MatteoRobbiati ad40a8b
chore: updating lock
MatteoRobbiati a609dfa
chore: rerun pre-commit
MatteoRobbiati 97a1568
chore: updating pre-commit once more
MatteoRobbiati 13789e5
chore: aligning pre-commit with Qibo's
MatteoRobbiati e510c8b
fix: conflicts in pre-commit config with main
MatteoRobbiati 29ca504
test: add conftest and first observable test
MatteoRobbiati 4cc1452
adapt pre-commit to qibo's one
MatteoRobbiati 67b900b
fix: set config_backend as normal method and not abstract method (for…
MatteoRobbiati 08ad49e
feat: make statevector calculation optional
MatteoRobbiati 4a2362e
feat: add set_device method to TN abstract backend
MatteoRobbiati 1036075
fix: probabilities results in case of prob_type=U
MatteoRobbiati d15a3d9
refactor: renaming expectation test
MatteoRobbiati f420a94
test: circuit execution
MatteoRobbiati f6992b4
Merge branch 'matcha' of github.com:qiboteam/qibotn into matcha
MatteoRobbiati 8b7bb9e
doc: improving the docs
MatteoRobbiati 65b60e0
fix: probabilities method in result class
MatteoRobbiati 39ed3eb
doc: use qibo's GHZ state function
MatteoRobbiati 72ba416
Apply suggestions from code review
MatteoRobbiati 938bf13
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] d959c95
Merge branch 'matcha' of github.com:qiboteam/qibotn into matcha
MatteoRobbiati 3e9189e
refactor: probabilities are now returned as an array, being aligned w…
MatteoRobbiati d854d15
fix: add link to api reference
MatteoRobbiati a5f7d1f
refactor: make QibotnBackend abstract and inherit both this and Numpy…
MatteoRobbiati 30c3bba
fix: change the order or the inheritance to impose the correct __mro__
MatteoRobbiati 97d2c79
doc: improve docstrings related to TensorNetworkResult
MatteoRobbiati 309fdc9
fix: importing QmatchateaBackend inside proper condition in the __ini…
MatteoRobbiati 4683c60
Update src/qibotn/result.py
MatteoRobbiati afc6c5d
Update src/qibotn/backends/qmatchatea.py
MatteoRobbiati bb76e2b
refactor: rewrite the expectation method using Qibo built in features
MatteoRobbiati 5b63877
refactor: adapt the example to the new expectation function
MatteoRobbiati 292d357
feat: improve the configure_tn_simulation function so that we don't n…
MatteoRobbiati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
QCConvergenceParameters
comes from matcha right? I would argue that it would be better not to ask a qibo user to deal with matcha objects ideally. Maybe we could have an analogue qibo object that interfaces to the different convergence parameters of the backends, the `QCConvergenceParameters`` in this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I can document the
configure_tn_simulation
listing the possible arguments which can be used to setup theQCConvergenceParameters
.Something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, I still think it would be better not to expose to the user objects that are not
qibo
'sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about now? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect thanks!