-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: server stop send websocket close message #420
fix: server stop send websocket close message #420
Conversation
Code Coverage Report
|
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 62.72% 62.80% +0.08%
==========================================
Files 211 210 -1
Lines 12511 12513 +2
==========================================
+ Hits 7847 7859 +12
+ Misses 4664 4654 -10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
for issue 441
While server stop websocket send close frame to connected client.
Before modification:
The client enters the error handling process.
After modification:
The client enters the close handling process.