Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, improve and add ut #436

Merged
merged 4 commits into from
Nov 10, 2023
Merged

fix, improve and add ut #436

merged 4 commits into from
Nov 10, 2023

Conversation

qicosmos
Copy link
Owner

@qicosmos qicosmos commented Nov 8, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (3a99afb) 65.05% compared to head (5e3c5bd) 65.22%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   65.05%   65.22%   +0.17%     
==========================================
  Files         217      217              
  Lines       13297    13365      +68     
==========================================
+ Hits         8650     8717      +67     
- Misses       4647     4648       +1     
Files Coverage Δ
include/cinatra/coro_http_connection.hpp 94.84% <ø> (ø)
include/cinatra/websocket.hpp 82.75% <80.00%> (+1.19%) ⬆️
tests/test_coro_http_server.cpp 85.41% <89.28%> (+1.65%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qicosmos qicosmos changed the title improve adn add ut fix, improve and add ut Nov 10, 2023
@qicosmos qicosmos merged commit e0b36e7 into master Nov 10, 2023
21 of 22 checks passed
@qicosmos qicosmos deleted the improve_coro_ws branch November 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants