-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:add br support #600
feat:add br support #600
Conversation
Code Coverage Report
|
Code Coverage Report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 70.45% 65.28% -5.17%
==========================================
Files 233 222 -11
Lines 13882 13921 +39
==========================================
- Hits 9780 9089 -691
- Misses 4102 4832 +730 ☔ View full report in Codecov by Sentry. |
Code Coverage Report
|
已经完成所有review修改 |
Code Coverage Report
|
Code Coverage Report
|
resp_data结构体中增加的 下面的代码也还有问题: #ifdef CINATRA_ENABLE_GZIP
if (encoding_type_ == content_encoding::gzip) {
std::string unziped_str;
bool r = gzip_codec::uncompress(reply, unziped_str);
if (r)
data.resp_body = unziped_str;
else
data.resp_body = reply;
}
else if (encoding_type_ == content_encoding::deflate) {
std::string inflate_str;
bool r = gzip_codec::inflate(reply, inflate_str);
if (r)
data.resp_body = inflate_str;
else
data.resp_body = reply;
}
#endif 其中 |
已经修复,最新代码使用单一变量uncompressed_str_作为解压缩后的字符。 |
Code Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Coverage Report
|
add br compression support.
server code:
python client test code:
Test pass.