-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Makefile #5
base: master
Are you sure you want to change the base?
Conversation
Please rebase your code before submit pr. |
Makefile
Outdated
all: check build | ||
|
||
.PHONY: check | ||
check: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need an alone check target, no one will do make check
directly.
Makefile
Outdated
else | ||
@echo 'OK' | ||
endif | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a make release
to build zip package which can be installed directly.
I have updated Makefile. |
.gitignore
Outdated
@@ -6,3 +6,6 @@ | |||
# composer | |||
vendor | |||
composer.lock | |||
|
|||
#release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unuseful comment should be removed.
|
||
.PHONY: clean | ||
clean: | ||
rm -rf ${CURDIR}/vendor ${CURDIR}/composer.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should end with an empty line.
The changes looks good to me, I will ACK if updated again. And your branch should rebase with the lastest master commit, |
No description provided.