Added Makefile #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase your code before submit pr. |
Xuanwo
suggested changes
May 20, 2017
Makefile
Outdated
| all: check build | ||
|
|
||
| .PHONY: check | ||
| check: |
There was a problem hiding this comment.
Don't need an alone check target, no one will do make check directly.
Makefile
Outdated
| else | ||
| @echo 'OK' | ||
| endif | ||
|
|
There was a problem hiding this comment.
We need to add a make release to build zip package which can be installed directly.
|
I have updated Makefile. |
Xuanwo
suggested changes
May 21, 2017
.gitignore
Outdated
| @@ -6,3 +6,6 @@ | |||
| # composer | |||
| vendor | |||
| composer.lock | |||
|
|
|||
| #release | |||
There was a problem hiding this comment.
Unuseful comment should be removed.
|
|
||
| .PHONY: clean | ||
| clean: | ||
| rm -rf ${CURDIR}/vendor ${CURDIR}/composer.lock |
There was a problem hiding this comment.
Should end with an empty line.
|
The changes looks good to me, I will ACK if updated again. And your branch should rebase with the lastest master commit, |
ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.