Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Support environment variables #120

Merged
merged 2 commits into from
Jan 21, 2021
Merged

config: Support environment variables #120

merged 2 commits into from
Jan 21, 2021

Conversation

zhaohuxing
Copy link
Contributor

  • QINGSTOR_CONFIG_PATH
  • QINGSTOR_ACCESS_KEY_ID
  • QINGSTOR_SECRET_ACCESS_KEY

Xuanwo
Xuanwo reviewed Jan 20, 2021
View reviewed changes
config/contract.go Outdated Show resolved Hide resolved
config/contract.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
@Xuanwo Xuanwo requested a review from Prnyself January 20, 2021 09:35
@zhaohuxing
Support environment variables:
0440313 
* QINGSTOR_CONFIG_PATH
* QINGSTOR_ACCESS_KEY_ID
* QINGSTOR_SECRET_ACCESS_KEY
@Xuanwo
Copy link
Contributor

Xuanwo commented Jan 20, 2021

Please don't force push, just append new commits to keep a log for reveiws and changes.

@Xuanwo Xuanwo changed the title Support environment variables: config: Support environment variables Jan 21, 2021
@Xuanwo Xuanwo merged commit 653ad2a into qingstor:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@Prnyself Prnyself Awaiting requested review from Prnyself

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaohuxing @Xuanwo