change mysql encode set #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknwon
suggested changes
Jun 28, 2018
reader/rest_reader_models.go
Outdated
| DefaultNoUse: false, | ||
| Description: "编码方式(encoding)", | ||
| Advance: true, | ||
| ToolTip: "读取日志文件的编码方式，默认为utf-8，即按照utf-8的编码方式读取文件", | ||
| ToolTip: "读取日志文件的编码方式，默认为utf8，即按照utf8的编码方式读取文件", |
There was a problem hiding this comment.
这里用“日志文件”的描述准确吗？不如一次性改好写成“读取数据库的编码方式，默认为utf8，即按照utf8的编码方式读取数据库”？
There was a problem hiding this comment.
这边重新用了一个新的属性keymysqlencoding，这个keyencoding在别的地方用到了，不好改
reader/sql/sql.go
Outdated
| encoder, _ = conf.GetStringOr(reader.KeyEncoding, "utf8") | ||
| if strings.Contains(encoder, "-") { | ||
| encoder = strings.Replace(encoder, "-", "", -1) | ||
| } |
There was a problem hiding this comment.
如果要兼容老配置，还应该强转小写 strings.ToLower()（当然。。可能老配置从来就没成功过）
unknwon
approved these changes
Jun 28, 2018
|
红姐说的都对，LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wonderflow
@unknwon