make qiniu log parser more flexiable #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
我觉得这块代码还是需要树伟来review下靠谱点... 我看不太出具体问题 |
unknwon
reviewed
Aug 17, 2018
parser/qiniu/qiniu.go
Outdated
| const ( | ||
| LogFilePattern = ":\\d+:$" | ||
|
|
||
| QiniulogHeadPatthern = `[1-9]\d{3}\/[0-1]\d\/[0-3]\d [0-2]\d:[0-6]\d:[0-6]\d(\.\d{6})? \[` |
There was a problem hiding this comment.
s/QiniulogHeadPatthern/HeadPatthern/
parser/qiniu/qiniu.go
Outdated
| LogFilePattern = ":\\d+:$" | ||
|
|
||
| QiniulogHeadPatthern = `[1-9]\d{3}\/[0-1]\d\/[0-3]\d [0-2]\d:[0-6]\d:[0-6]\d(\.\d{6})? \[` | ||
| KeyQiniulogPrefix = "qiniulog_prefix" //qiniulog的日志前缀 |
There was a problem hiding this comment.
s/KeyQiniulogPrefix/KeyPrefix/
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [issue number]
Changes
Reviewers
Wiki Changes
Checklist