This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Allow Custom Lambda for Iterative Grover, see #893 #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix problem with variable bounds in cobyla optimizer and add unit test * derive initial state from variable bounds Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Iterative Grover Allows Custom Lambda 1) Parameter "lam" can be explicitly set in constructor, with default value 1.34, which is proved to be optimal 2) Sequence of Grover rotation counts can be explicitly set in the constructor, e.g. rotation_counts = [ 0, 1, 3, 5, 9 ]
Iterative Grover Allows Custom Lambda - grover_test parametrised by rotation_counts - if rotations_counts is None, the number of iterations increases by the factor of lambda - the fixed rotation sequence [0, 0, ..., 49, 4, 60 ] is efficient choice according to Baritompa et al., Grovers Quantum Algorithm Applied to Global Optimization
molar-volume
requested review from
manoelmarques,
stefan-woerner and
woodsp-ibm
as code owners
Cryoris
changed the title
Cryoris
added
the
Changelog: New Feature
woodsp-ibm
suggested changes
May 20, 2020
There was a problem hiding this comment.
This has changes that revert the 2 files that were updated in PR #997. Can this PR be updated to avoid this revert which should not happen.
* Replace algorithm result eigvecs by eingenstate * remove return type from docstring
|
sorry for that @woodsp-ibm, |
woodsp-ibm
approved these changes
May 21, 2020
|
Thanks for the contribution and persevering with the CLA etc to make it happen :) |
|
My pleasure. Thanks for your assistance @woodsp-ibm . |
|
Thank you @molar-volume 👍 We should add a test for setting the |
|
Hi @Cryoris , |
|
That'd be great, thanks. You don't have to reference the issue anymore, you can just put something like "Test |
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…-aqua#893 (qiskit-community/qiskit-aqua#1005) * qiskit-community/qiskit-aqua#893 Iterative Grover Allows Custom Lambda 1) Parameter "lam" can be explicitly set in constructor, with default value 1.34, which is proved to be optimal 2) Sequence of Grover rotation counts can be explicitly set in the constructor, e.g. rotation_counts = [ 0, 1, 3, 5, 9 ] Iterative Grover Allows Custom Lambda - grover_test parametrised by rotation_counts - if rotations_counts is None, the number of iterations increases by the factor of lambda - the fixed rotation sequence [0, 0, ..., 49, 4, 60 ] is efficient choice according to Baritompa et al., Grovers Quantum Algorithm Applied to Global Optimization Co-authored-by: Stefan Woerner <41292468+stefan-woerner@users.noreply.github.com> Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: Manoel Marques <manoel@us.ibm.com>
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…-aqua#893 (qiskit-community/qiskit-aqua#1005) * qiskit-community/qiskit-aqua#893 Iterative Grover Allows Custom Lambda 1) Parameter "lam" can be explicitly set in constructor, with default value 1.34, which is proved to be optimal 2) Sequence of Grover rotation counts can be explicitly set in the constructor, e.g. rotation_counts = [ 0, 1, 3, 5, 9 ] Iterative Grover Allows Custom Lambda - grover_test parametrised by rotation_counts - if rotations_counts is None, the number of iterations increases by the factor of lambda - the fixed rotation sequence [0, 0, ..., 49, 4, 60 ] is efficient choice according to Baritompa et al., Grovers Quantum Algorithm Applied to Global Optimization Co-authored-by: Stefan Woerner <41292468+stefan-woerner@users.noreply.github.com> Co-authored-by: Julien Gacon <jules.gacon@googlemail.com> Co-authored-by: Manoel Marques <manoel@us.ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved here from #1001.
Details and comments
Closes #893.