This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Fix ADAM resuseability #1016
Merged
Fix ADAM resuseability #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoufalc
approved these changes
May 26, 2020
woodsp-ibm
added
the
Changelog: Bugfix
woodsp-ibm
approved these changes
May 26, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
* reset step count in minimize and set params_new * remove duplicate loc
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
* reset step count in minimize and set params_new * remove duplicate loc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1007 (lines 181 and 191) and updates the documentation and type hints of
ADAM.Details and comments
The number of iterations was set in the initializer only, so re-running the optimization kept increasing the number of iterations. Since there's a maximum number of iterations,
ADAMstopped the optimization.