This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Enhanced Aqgd optimizer #1252
Merged
Enhanced Aqgd optimizer #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch qiskit master
pbark
requested review from
levbishop,
manoelmarques and
woodsp-ibm
as code owners
� Conflicts: � qiskit/aqua/components/optimizers/aqgd.py
|
@pbark Could you please add a reno file with a description of the changes? |
woodsp-ibm
suggested changes
Sep 16, 2020
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
|
CI failed at: |
I restarted the CI. Locally I pass all the tests. |
woodsp-ibm
reviewed
Sep 17, 2020
| self._tol = tol | ||
| self._averaging = averaging | ||
| if disp: | ||
| warnings.warn('disp deprecated, enable logging instead.', DeprecationWarning) |
There was a problem hiding this comment.
Can we include the more complete text such as below (I tried as a suggestion but the formatting seemed all over the place while it lines up fine in this view while I am editing it, it does not in the outcome
warnings.warn('The disp parameter is deprecated as of '
'0.8.0 and will be removed no sooner than 3 months after the release. '
'The information is now available if you enable INFO level logging.',
DeprecationWarning, stacklevel=2)
woodsp-ibm
reviewed
Sep 17, 2020
| seed_simulator=aqua_globals.random_seed, | ||
| seed_transpiler=aqua_globals.random_seed)) | ||
| self.assertAlmostEqual(result.eigenvalue.real, -1.857275, places=5) | ||
| q_instance = QuantumInstance(BasicAer.get_backend('statevector_simulator'), |
There was a problem hiding this comment.
Can we please split this into 3 separate tests so if there is a failure its easier to pinpoint it to a specific test aspect
woodsp-ibm
added
the
Changelog: New Feature
woodsp-ibm
approved these changes
Sep 20, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
* new advanced aqgd added * fix in license * cleaning, linting * spelling * more spelling * reno added * Update qiskit/aqua/components/optimizers/aqgd.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Update qiskit/aqua/components/optimizers/aqgd.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * code review * updated release note aqgd * code review 2 Co-authored-by: Anton Dekusar <adekusar@ie.ibm.com> Co-authored-by: Anton Dekusar <62334182+adekusar-drl@users.noreply.github.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
manoelmarques
pushed a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
* new advanced aqgd added * fix in license * cleaning, linting * spelling * more spelling * reno added * Update qiskit/aqua/components/optimizers/aqgd.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * Update qiskit/aqua/components/optimizers/aqgd.py Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> * code review * updated release note aqgd * code review 2 Co-authored-by: Anton Dekusar <adekusar@ie.ibm.com> Co-authored-by: Anton Dekusar <62334182+adekusar-drl@users.noreply.github.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New advanced AQDG optimizer using Epochs added
Details and comments