Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Fix seed_simulator=0 in the quantum instance #1410

Merged
merged 6 commits into from
Nov 5, 2020

Conversation

Cryoris
Copy link
Contributor

@Cryoris Cryoris commented Nov 4, 2020

Summary

Fixes #1408.

Details and comments

Replaces a check for None from if seed_simulator to if seed_simulator is None to cover the case of seed_simulator=0.

@Cryoris Cryoris added the Changelog: Bugfix Include in the Fixed section of the changelog label Nov 4, 2020
manoelmarques
manoelmarques previously approved these changes Nov 4, 2020
manoelmarques
manoelmarques previously approved these changes Nov 5, 2020
@manoelmarques manoelmarques merged commit 367bc9d into qiskit-community:master Nov 5, 2020
@manoelmarques manoelmarques added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 9, 2020
manoelmarques added a commit to manoelmarques/qiskit-aqua that referenced this pull request Nov 9, 2020
* fix seed 0

* add reno

* change seed

* change seed

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
mtreinish pushed a commit to mtreinish/qiskit-core that referenced this pull request Nov 20, 2020
…skit-aqua#1410)

* fix seed 0

* add reno

* change seed

* change seed

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
manoelmarques added a commit to manoelmarques/qiskit-terra that referenced this pull request Nov 23, 2020
…skit-aqua#1410)

* fix seed 0

* add reno

* change seed

* change seed

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
manoelmarques added a commit to manoelmarques/qiskit-terra that referenced this pull request Dec 7, 2020
…skit-aqua#1410)

* fix seed 0

* add reno

* change seed

* change seed

Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting seed_simulator on QuantumInstance does not seed the simulator
3 participants