This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 376
Fix seed_simulator=0
in the quantum instance
#1410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
levbishop,
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
November 4, 2020 16:52
manoelmarques
previously approved these changes
Nov 4, 2020
manoelmarques
previously approved these changes
Nov 5, 2020
manoelmarques
force-pushed
the
seed-simulator
branch
from
November 5, 2020 20:36
45f07f7
to
aaac4f8
Compare
manoelmarques
approved these changes
Nov 5, 2020
woodsp-ibm
approved these changes
Nov 5, 2020
manoelmarques
added
the
stable backport potential
The bug might be minimal and/or import enough to be port to stable
label
Nov 9, 2020
manoelmarques
added a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Nov 9, 2020
* fix seed 0 * add reno * change seed * change seed Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
mtreinish
pushed a commit
to mtreinish/qiskit-core
that referenced
this pull request
Nov 20, 2020
…skit-aqua#1410) * fix seed 0 * add reno * change seed * change seed Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Nov 23, 2020
…skit-aqua#1410) * fix seed 0 * add reno * change seed * change seed Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
manoelmarques
added a commit
to manoelmarques/qiskit-terra
that referenced
this pull request
Dec 7, 2020
…skit-aqua#1410) * fix seed 0 * add reno * change seed * change seed Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Changelog: Bugfix
Include in the Fixed section of the changelog
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1408.
Details and comments
Replaces a check for
None
fromif seed_simulator
toif seed_simulator is None
to cover the case ofseed_simulator=0
.