This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Fix migration guide and code msgs for aqua_globals #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplewa
requested review from
levbishop,
manoelmarques and
woodsp-ibm
as code owners
|
|
|
Thanks for the correction - it was moved and later renamed. Seems that last part we slipped on an did not update here too. FYI: CI is failing because of a problem in a library we use, where something it depends on was recently updated and has caused a breakage |
|
Thanks for noticing and fixing this. I added to this PR places in the code where the deprecation msg is wrong. |
manoelmarques
added
the
stable backport potential
woodsp-ibm
approved these changes
Apr 4, 2021
manoelmarques
added a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Apr 13, 2021
* Fix migration guide for aqua_globals * Fix deprecation msg for aqua_globals Co-authored-by: Manoel Marques <manoel.marques@ibm.com>
manoelmarques
added a commit
that referenced
this pull request
Apr 13, 2021
manoelmarques
changed the title
manoelmarques
added
the
Changelog: Bugfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The migration guide currently says to replace
qiskit.aqua.aqua_globalswithqiskit.utils.aqua_globals, howeverqiskit.utils.aqua_globalsdoes not seem to exist. It would appear thatqiskit.utils.algorithm_globalsis the correct import.Details and comments
I updated
README.mdwith what I believe to be the correct import. Apologies if I'm wrong - it's sort of hard to make sense of all these changes at once, so do correct me if I'm missing something :)