Update BaseCalibrationExperiment for composite experiment #1033
Conversation
nkanazawa1989
added
the
Changelog: Bugfix
| @@ -148,6 +148,37 @@ def calibrations(self) -> Calibrations: | |||
| """Return the calibrations.""" | |||
| return self._cals | |||
|
|
|||
| @property | |||
| def analysis(self) -> Union[BaseAnalysis, None]: | |||
There was a problem hiding this comment.
What's the reason to redefine here, if already defined in BaseExperiment?
There was a problem hiding this comment.
We can also do @BaseExperiment.analysis.setter but we cannot override only setter in the subclass as far as I understand.
|
|
||
| @analysis.setter | ||
| def analysis(self, analysis: Union[BaseAnalysis, None]) -> None: | ||
| """Set the analysis instance for the experiment""" |
There was a problem hiding this comment.
Can you add a bit of doc here to state that this is here so that update calibrations is called and so that this also works with composite experiments.
There was a problem hiding this comment.
note section is added to the property method rather than here. I think setter method doesn't appear in the API doc and one needs to read the code anyways to find the comment. Note that such comment is already in the method. Now note will appear with the updated property method.
releasenotes/notes/fix-missing_calibration_updator_call-a255b28dd1449ea4.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel J. Egger <38065505+eggerdj@users.noreply.github.com>
Summary
This PR updates the mechanism to invoke
update_calibrationsmethod so that it can be called from the composite experiment.fix #969
Details and comments
Composite experiment only takes circuits from individual experiment instance and calls analysis.run of each experiment. If
update_calibrationsis called from experiment.run it will be never called from the composite experiments. This indicates we need to formally implement post analysis or chained analysis to update calibrations. However, this is overkill just to update calibrations. This PR implements minimum logic to invoke the updator as a part of analysis.run.Since unittest coverage is almost zero for composite calibration experiments, I newly added several unittests.