Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop qiskit-ibmq-provider requirement and integration tests #1062

Merged

Conversation

coruscating
Copy link
Collaborator

Closes #1056. qiskit-ibmq-provider is deprecated and no longer required. Gadi has already set up the cron integration tests in qiskit-ibm-experiment, so the tests can be removed from this repository.

tox.ini Show resolved Hide resolved
Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

cron-staging.yml is pretty close to main.yml now. It makes me wonder if we should do something like suggested here to merge the two together by putting a if: ${{ github.event_name != 'schedule' }} on the test running step.

@coruscating coruscating added this to the Release 0.5 milestone Mar 1, 2023
Co-authored-by: Will Shanks <wshaos@posteo.net>
@coruscating
Copy link
Collaborator Author

Thanks, I'll make a separate PR for merging the workflow files.

Copy link
Contributor

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add an optional dependency (via setuptools extras) because there is code in the tree which optionally will use the ibmq provider still: https://github.com/Qiskit/qiskit-experiments/blob/main/qiskit_experiments/database_service/utils.py#L31-L34

@coruscating
Copy link
Collaborator Author

Actually, I think those exceptions are in the experiments service now, so I've gotten rid of the optional IBMQ dependency. Thanks for catching that.

@wshanks
Copy link
Collaborator

wshanks commented Mar 1, 2023

Actually, I think those exceptions are in the experiments service now, so I've gotten rid of the optional IBMQ dependency. Thanks for catching that.

Nice to see that gone. Ideally there would be some way to catch an exception without needing to assume a specific experiment service implementation. I suppose any alternative service could make qiskit-experiments a dependency and use ExperimentEntryNotFound. qiskit-ibm-experiment could not do that because we wanted it split out as a dependency of qiskit-experiments.

@coruscating coruscating enabled auto-merge March 1, 2023 21:07
@coruscating coruscating added this pull request to the merge queue Mar 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 1, 2023
@coruscating coruscating added this pull request to the merge queue Mar 1, 2023
@coruscating coruscating removed this pull request from the merge queue due to the queue being cleared Mar 1, 2023
@coruscating coruscating added this pull request to the merge queue Mar 2, 2023
Merged via the queue into qiskit-community:main with commit 1a83308 Mar 2, 2023
@coruscating coruscating deleted the remove-integration-tests branch April 1, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move experiment data integration tests to qiskit-ibm-experiments
3 participants