-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop qiskit-ibmq-provider
requirement and integration tests
#1062
Drop qiskit-ibmq-provider
requirement and integration tests
#1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
cron-staging.yml is pretty close to main.yml now. It makes me wonder if we should do something like suggested here to merge the two together by putting a if: ${{ github.event_name != 'schedule' }}
on the test running step.
Co-authored-by: Will Shanks <wshaos@posteo.net>
Thanks, I'll make a separate PR for merging the workflow files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add an optional dependency (via setuptools extras) because there is code in the tree which optionally will use the ibmq provider still: https://github.com/Qiskit/qiskit-experiments/blob/main/qiskit_experiments/database_service/utils.py#L31-L34
…kit-experiments into remove-integration-tests
Actually, I think those exceptions are in the experiments service now, so I've gotten rid of the optional IBMQ dependency. Thanks for catching that. |
Nice to see that gone. Ideally there would be some way to catch an exception without needing to assume a specific experiment service implementation. I suppose any alternative service could make qiskit-experiments a dependency and use ExperimentEntryNotFound. qiskit-ibm-experiment could not do that because we wanted it split out as a dependency of qiskit-experiments. |
Closes #1056.
qiskit-ibmq-provider
is deprecated and no longer required. Gadi has already set up the cron integration tests inqiskit-ibm-experiment
, so the tests can be removed from this repository.