Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calibration tests to test _transpiled_circuits #1157

Merged
merged 4 commits into from
May 3, 2023

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Apr 28, 2023

Summary

Previously, the tests were calling transpile() on the output of experiment.circuits() even though
BaseCalibrationExperiment._transpiled_circuits() uses a custom pass manager and does not call transpile() itself.

Previously, the tests were calling `transpile()` on the output of
`experiment.circuits()` even though
`BaseCalibrationExperiment._transpiled_circuits()` uses a custom pass
manager and does not call `transpile()` itself.
@wshanks wshanks added backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: None Do not include in changelog labels Apr 28, 2023
@wshanks wshanks force-pushed the cal-transpile-tests branch from 6d38bcc to 558fe79 Compare April 28, 2023 16:37
@wshanks wshanks force-pushed the cal-transpile-tests branch from 558fe79 to b6ad468 Compare April 28, 2023 16:48
@wshanks wshanks marked this pull request as ready for review May 3, 2023 04:03
@wshanks wshanks requested a review from eggerdj May 3, 2023 04:03
Copy link
Contributor

@eggerdj eggerdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wshanks wshanks added this pull request to the merge queue May 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 3, 2023
@coruscating coruscating added this pull request to the merge queue May 3, 2023
Merged via the queue into qiskit-community:main with commit e19e45c May 3, 2023
mergify bot pushed a commit that referenced this pull request May 3, 2023
### Summary

Previously, the tests were calling `transpile()` on the output of
`experiment.circuits()` even though
`BaseCalibrationExperiment._transpiled_circuits()` uses a custom pass
manager and does not call `transpile()` itself.

(cherry picked from commit e19e45c)
coruscating pushed a commit that referenced this pull request May 4, 2023
#1162)

This is an automatic backport of pull request #1157 done by
[Mergify](https://mergify.com).


Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants