-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calibration tests to test _transpiled_circuits #1157
Merged
coruscating
merged 4 commits into
qiskit-community:main
from
wshanks:cal-transpile-tests
May 3, 2023
Merged
Update calibration tests to test _transpiled_circuits #1157
coruscating
merged 4 commits into
qiskit-community:main
from
wshanks:cal-transpile-tests
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the tests were calling `transpile()` on the output of `experiment.circuits()` even though `BaseCalibrationExperiment._transpiled_circuits()` uses a custom pass manager and does not call `transpile()` itself.
wshanks
added
backport stable potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: None
Do not include in changelog
labels
Apr 28, 2023
wshanks
force-pushed
the
cal-transpile-tests
branch
from
April 28, 2023 16:37
6d38bcc
to
558fe79
Compare
wshanks
force-pushed
the
cal-transpile-tests
branch
from
April 28, 2023 16:48
558fe79
to
b6ad468
Compare
eggerdj
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 3, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 3, 2023
### Summary Previously, the tests were calling `transpile()` on the output of `experiment.circuits()` even though `BaseCalibrationExperiment._transpiled_circuits()` uses a custom pass manager and does not call `transpile()` itself. (cherry picked from commit e19e45c)
coruscating
pushed a commit
that referenced
this pull request
May 4, 2023
#1162) This is an automatic backport of pull request #1157 done by [Mergify](https://mergify.com). Co-authored-by: Will Shanks <willshanks@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport stable potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: None
Do not include in changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, the tests were calling
transpile()
on the output ofexperiment.circuits()
even thoughBaseCalibrationExperiment._transpiled_circuits()
uses a custom pass manager and does not calltranspile()
itself.