Adding Test for Circuit Serialization #1176

ItamarGoldman · 2023-05-15T13:38:42Z

Summary

Adding circuit serialization tests to qiskit-experiments package as suggested in #1063

PR checklist

Add test to the following experiments:

In addition, I fixed the the code of the following experiments:

Rabi Experiment - cast the amplitudes to float type after rounding so the the variable type will be serializable.
QV Experiment - casting the result (the probabilities) into a list so it will be serializable.

Updating main

This reverts commit 4d954d2.

wshanks · 2023-05-17T20:35:11Z

@ItamarGoldman This looks good to me, but Chris made a suggestion here of using the json serializer rather than the qpy functions directly. I didn't update #1059 to follow that suggestion. Have you looked at that option?

coruscating · 2023-05-19T19:49:06Z

Another issue came up when I was testing #1183. QV circuits are currently not serializable when Aer isn't installed because Statevector.probabilities() returns a numpy array:

https://github.com/Qiskit/qiskit-experiments/blob/38678c283f1d2463792650a29492fb77f0170f26/qiskit_experiments/library/quantum_volume/qv_experiment.py#L157

This needs to be cast to a list and tests should be added that check both Aer and Aer-less circuits.

deleted the circuit test with 'qpy' lib as it is tested in the json serialization as mentioned in IS-1059

ItamarGoldman · 2023-05-28T10:11:29Z

@ItamarGoldman This looks good to me, but Chris made a suggestion here of using the json serializer rather than the qpy functions directly. I didn't update #1059 to follow that suggestion. Have you looked at that option?

Thanks! I changed the serialization to be used with the json serialization method (I used 'assertRoundTripSerializable(exp)' ) I will add the tests to other experiments.

reorganize 'test_state_tomography.py'

Added a test that create an experiment and then serialize it.

deleted 'test_circuit_serialization' function from standard RB as the roundtrip serialization of the experiment is already checking serialization of the quantum circuit.

Added serialization tests for half angle Experiment and ExperimentData objects.

coruscating

Thanks for working on this. Please write a release note describing the bug fixes for Rabi and QV experiments.

coruscating · 2023-07-10T19:51:13Z

test/library/calibration/test_drag.py

+        drag = RoughDrag([0], self.x_plus)
+        drag.set_experiment_options(reps=[2, 4, 8])
+        drag.backend = FakeWashingtonV2()
+        self.assertRoundTripSerializable(drag._transpiled_circuits())


Why are some tests on _transpiled_circuits() while others are on circuits()?

Although I didn't see a reason to use _transpiled_circuits(), I tried to use the same method as the other tests used to be on the safe side but I don't think it is necessary (from my checks, there is no difference).
Should I change it to circuits() instead?

I think _transpiled_circuits() makes more sense since those are the actual circuits being serialized and run on the backend, right? For most cases, there shouldn't be a difference but I think we should be consistent.

I chose to use circuits() or _transpiled_circuits() by matching what method the other tests in the class are using. Should I change all the other to be _transpiled_circuits() or should I leave it as is?

Yes, let's change them all to _transpiled_circuits(), then I think the PR should be ready to go.

test/library/characterization/test_cross_resonance_hamiltonian.py

Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

… into IS_1063

CLAassistant · 2023-07-18T13:25:42Z

All committers have signed the CLA.

### Summary This PR adds `requirements-extras.txt` which contains extra packages that can be installed as `[extras]` and were mostly moved from `requirements-dev.txt`. These are in contrast to the core dependencies in `requirements.txt` and the requirements that are only used for tests, which will stay in `requirements-dev.txt`. ### Details and comments While the optional packages are not related to each other, it seemed too complicated to split out optional dependencies into further categories. There are a few additional changes: - Added `qiskit-ibm-provider>=0.6.1` as an optional dependency since this release adds numpy serialization, which fixes some known bugs with circuit metadata serialization (see also #1176) - Unpinned `scipy` (done in #1164) and bumped `cvxpy` to 1.3.2, which is now compatible with scipy 1.11 - Removed matrix variables from CI workflow that doesn't use them - Updated install and contributing instructions

qiskit_experiments/library/quantum_volume/qv_experiment.py

eliarbel

Also +1 for Helena's comment to test _transpiled_circuits() instead of circuits()

test/library/calibration/test_fine_amplitude.py

test/library/characterization/test_cross_resonance_hamiltonian.py

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

…der calibration

… into IS_1063

… tests

coruscating

This looks good besides one minor comment. If @eliarbel also thinks it's good then it can be merged after that.

releasenotes/notes/rabi-and-qv-bugfix-34636baee6651af1.yaml

eliarbel

ProcessTomography test should use _transpiled_circuits

test/library/tomography/test_process_tomography.py

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

eliarbel

LGTM! Thanks Itamar

### Summary Adding circuit serialization tests to qiskit-experiments package as suggested in qiskit-community#1063 ### PR checklist Add test to the following experiments: - [x] Calibration experiments. - [x] Characterization experiments. - [x] QV experiment. - [x] RB experiments. - [x] Tomography experiments. In addition, I fixed the the code of the following experiments: - [x] Rabi Experiment - cast the amplitudes to `float` type after rounding so the the variable type will be serializable. - [x] QV Experiment - casting the result (the probabilities) into a list so it will be serializable. --------- Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com> Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

ItamarGoldman and others added 18 commits August 16, 2021 14:52

Test Changes

15e9ba7

Test Changes

1f17fbe

Merge branch 'Qiskit:main' into main

5b623ee

Merge remote-tracking branch 'upstream/main'

95927a2

Merge remote-tracking branch 'upstream/main'

1254c27

Merge remote-tracking branch 'upstream/main'

05ede3a

Merge remote-tracking branch 'upstream/main'

778a02e

Merge remote-tracking branch 'upstream/main'

3ece164

Merge remote-tracking branch 'upstream/main'

366a11b

Merge remote-tracking branch 'upstream/main'

c4b9d8c

Merge remote-tracking branch 'upstream/main'

fee505a

Merge remote-tracking branch 'upstream/main'

04735fe

Merge remote-tracking branch 'upstream/main'

b8c3c60

Added circuit serialization test to Standart RB experiment

4d954d2

Merge branch 'main' of github.com:ItamarGoldman/qiskit-experiments

fe521e5

Updating main

Revert "Added circuit serialization test to Standart RB experiment"

401e54a

This reverts commit 4d954d2.

Added circuit serialization test to Standart RB experiment

90abbaa

fix typo

5990885

ItamarGoldman added 2 commits May 28, 2023 13:07

Added test for experiment serialization

42b8fab

Removed 'test_circuit_serialization' with qpy

020d06b

deleted the circuit test with 'qpy' lib as it is tested in the json serialization as mentioned in IS-1059

ItamarGoldman added 7 commits May 28, 2023 13:12

Merge remote-tracking branch 'upstream/main' into IS_1063

a50585c

deleted unused import (io, qpy)

8f3b4c6

Update test_state_tomography.py

21ef411

reorganize 'test_state_tomography.py'

Added test for experiment serialization for 'process tomography'

5b34c27

Added a test that create an experiment and then serialize it.

deleted 'test_circuit_serialization' function

304841c

deleted 'test_circuit_serialization' function from standard RB as the roundtrip serialization of the experiment is already checking serialization of the quantum circuit.

Added serialization tests for half angle experiment.

2635493

Added serialization tests for half angle Experiment and ExperimentData objects.

Added serialization of the experiment to the test

420b92b

ItamarGoldman added 2 commits July 3, 2023 16:12

pylint

e683042

fixed deprecation warning

b6de8fb

coruscating mentioned this pull request Jul 7, 2023

Add optional dependencies file #1219

Merged

Merge remote-tracking branch 'upstream/main' into IS_1063

f6397cc

ItamarGoldman changed the title ~~[WIP] Adding Test for Circuit Serialization~~ Adding Test for Circuit Serialization Jul 9, 2023

black

27f2cf6

coruscating reviewed Jul 11, 2023

View reviewed changes

ItamarGoldman and others added 4 commits July 16, 2023 12:59

Update test/library/characterization/test_cross_resonance_hamiltonian.py

960cbf8

Co-authored-by: Helena Zhang <Helena.Zhang@ibm.com>

updated function name

8bcd570

Merge branch 'IS_1063' of github.com:ItamarGoldman/qiskit-experiments…

2a42c84

… into IS_1063

Added release notes.

c906b04

Merge remote-tracking branch 'upstream/main' into IS_1063

881e9fd

eliarbel reviewed Jul 30, 2023

View reviewed changes

qiskit_experiments/library/quantum_volume/qv_experiment.py Show resolved Hide resolved

eliarbel suggested changes Jul 30, 2023

View reviewed changes

test/library/calibration/test_fine_amplitude.py Outdated Show resolved Hide resolved

test/library/characterization/test_cross_resonance_hamiltonian.py Outdated Show resolved Hide resolved

ItamarGoldman and others added 5 commits July 30, 2023 16:57

Update qv_experiment.py

dcb137d

Update test/library/characterization/test_cross_resonance_hamiltonian.py

31c8200

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

matched circuit() or _transpiled_circuits() to the other tests un…

0326073

…der calibration

Merge branch 'IS_1063' of github.com:ItamarGoldman/qiskit-experiments…

cd14960

… into IS_1063

changed circuits() to _transpiled_circuits() in all serialization…

968c14b

… tests

coruscating reviewed Aug 2, 2023

View reviewed changes

releasenotes/notes/rabi-and-qv-bugfix-34636baee6651af1.yaml Outdated Show resolved Hide resolved

changed the release notes text

38ef2cb

eliarbel suggested changes Aug 10, 2023

View reviewed changes

test/library/tomography/test_process_tomography.py Outdated Show resolved Hide resolved

Update test/library/tomography/test_process_tomography.py

3667bad

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

eliarbel approved these changes Aug 13, 2023

View reviewed changes

coruscating added this pull request to the merge queue Aug 14, 2023

Merged via the queue into qiskit-community:main with commit c66034c Aug 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Test for Circuit Serialization #1176

Adding Test for Circuit Serialization #1176

ItamarGoldman commented May 15, 2023 •

edited

Loading

wshanks commented May 17, 2023

coruscating commented May 19, 2023

ItamarGoldman commented May 28, 2023

coruscating left a comment

coruscating Jul 10, 2023

ItamarGoldman Jul 16, 2023

coruscating Jul 16, 2023

ItamarGoldman Jul 31, 2023

coruscating Jul 31, 2023

CLAassistant commented Jul 18, 2023 •

edited

Loading

eliarbel left a comment

coruscating left a comment

eliarbel left a comment

eliarbel left a comment •

edited

Loading

Adding Test for Circuit Serialization #1176

Adding Test for Circuit Serialization #1176

Conversation

ItamarGoldman commented May 15, 2023 • edited Loading

Summary

PR checklist

wshanks commented May 17, 2023

coruscating commented May 19, 2023

ItamarGoldman commented May 28, 2023

coruscating left a comment

Choose a reason for hiding this comment

coruscating Jul 10, 2023

Choose a reason for hiding this comment

ItamarGoldman Jul 16, 2023

Choose a reason for hiding this comment

coruscating Jul 16, 2023

Choose a reason for hiding this comment

ItamarGoldman Jul 31, 2023

Choose a reason for hiding this comment

coruscating Jul 31, 2023

Choose a reason for hiding this comment

CLAassistant commented Jul 18, 2023 • edited Loading

eliarbel left a comment

Choose a reason for hiding this comment

coruscating left a comment

Choose a reason for hiding this comment

eliarbel left a comment

Choose a reason for hiding this comment

eliarbel left a comment • edited Loading

Choose a reason for hiding this comment

ItamarGoldman commented May 15, 2023 •

edited

Loading

CLAassistant commented Jul 18, 2023 •

edited

Loading

eliarbel left a comment •

edited

Loading