Adopt qiskit.result.mitigation into qiskit_experiments.data_processing
#1484
Conversation
|
This is a draft for now because it includes the changes from #1483 as well and is intended as a follow up. |
wshanks
added
the
backport stable potential
|
I also pushed this branch into the main repo so I could run the Cron-Staging workflow and it passed. |
| @@ -102,9 +93,9 @@ The individual mitigation matrices can be read off the mitigator. | |||
|
|
|||
| .. jupyter-execute:: | |||
|
|
|||
| for m in mitigator._mitigation_mats: | |||
There was a problem hiding this comment.
Besides changing the import location of the mitigators, I made some small changes to this manual to stop using private functions and methods.
| @@ -118,13 +109,9 @@ Mitigation example | |||
| qc.cx(i - 1, i) | |||
| qc.measure_all() | |||
|
|
|||
| .. jupyter-execute:: | |||
There was a problem hiding this comment.
I also merged adjacent jupyter-execute cells because they don't work well. In the rendered docs, they look like one big cell any way, but they still have individual buttons for copying the code to the clipboard, so you think you are copying the whole merged cell but you only get a subsection of it.
| @@ -143,16 +130,31 @@ Expectation value | |||
|
|
|||
| .. jupyter-execute:: | |||
|
|
|||
| def str2diag(string): | |||
There was a problem hiding this comment.
Why we have to define this function although you port this function to .data_processing.mitigation.utils?
Instead of using the util function, we can also write:
from qiskit.quantum_info import Operator
Operator.from_label("II0I").to_matrix()which looks much simpler.
There was a problem hiding this comment.
I didn't want to make .data_processing.mitigation.utils public and str2diag was the only code that I did not know how to replace with other public code. I thought there was probably something in Qiskit but I had not figured it out. I can try Operator.from_label.
There was a problem hiding this comment.
@nkanazawa1989 Operator.from_label worked. This is ready for review now.
No, it should be a straight copy from Qiskit besides changing some imports. |
The readout error mitigator classes `LocalReadoutMitigator` and `CorrelatedReadoutMitigator` have been copied into `qiskit_experiments.data_processing.mitigation` from `qiskit.result.mitigation` in order to prepare for the deprecation of these classes from Qiskit. The experiments that previously used the Qiskit versions of these mitigator classes now use the Experiments versions. The manual has also been updated to use the new class locations.
wshanks
force-pushed
the
adopt-mitigators
branch
from
23b3a5d to
eae85bf
Compare
…sing` (#1484) The readout error mitigator classes `LocalReadoutMitigator` and `CorrelatedReadoutMitigator` have been copied into `qiskit_experiments.data_processing.mitigation` from `qiskit.result.mitigation` in order to prepare for the deprecation of these classes from Qiskit. The experiments that previously used the Qiskit versions of these mitigator classes now use the Experiments versions. The manual has also been updated to use the new class locations. Additionally, the readout mitigation manual was refactored to avoid using private functions and methods. Some adjacent `jupyter-execute` cells were merged because in the rendered docs they look like one cell any way, but they still have individual "copy to clipboard" buttons which is confusing. You think clicking the button will get the merged cell contents but it only gets a section of it. (cherry picked from commit 940b94d)
…sing` (backport #1484) (#1486) The readout error mitigator classes `LocalReadoutMitigator` and `CorrelatedReadoutMitigator` have been copied into `qiskit_experiments.data_processing.mitigation` from `qiskit.result.mitigation` in order to prepare for the deprecation of these classes from Qiskit. The experiments that previously used the Qiskit versions of these mitigator classes now use the Experiments versions. The manual has also been updated to use the new class locations. Additionally, the readout mitigation manual was refactored to avoid using private functions and methods. Some adjacent `jupyter-execute` cells were merged because in the rendered docs they look like one cell any way, but they still have individual "copy to clipboard" buttons which is confusing. You think clicking the button will get the merged cell contents but it only gets a section of it.<hr>This is an automatic backport of pull request #1484 done by [Mergify](https://mergify.com). Co-authored-by: Will Shanks <willshanks@us.ibm.com>
The readout error mitigator classes
LocalReadoutMitigatorandCorrelatedReadoutMitigatorhave been copied intoqiskit_experiments.data_processing.mitigationfromqiskit.result.mitigationin order to prepare for the deprecation ofthese classes from Qiskit. The experiments that previously used the
Qiskit versions of these mitigator classes now use the Experiments
versions. The manual has also been updated to use the new class
locations.
Additionally, the readout mitigation manual was refactored to avoid using private functions and methods. Some adjacent
jupyter-executecells were merged because in the rendered docs they look like one cell any way, but they still have individual "copy to clipboard" buttons which is confusing. You think clicking the button will get the merged cell contents but it only gets a section of it.