This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Unconditionally depend on jupyter_sphinx for dev #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original constraint was added in qiskit-communitygh-505, at a time when Aer was specifically requiring jupyter_sphinx in its own `requirements-dev.txt` under certain constraints. The constraint no longer appears to be needed, so all it serves to do now is to cause the docs build to fail on Python 3.9.
17 tasks
mtreinish
approved these changes
Apr 5, 2022
mtreinish
pushed a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
May 17, 2022
The original constraint was added in qiskit-communitygh-505, at a time when Aer was specifically requiring jupyter_sphinx in its own `requirements-dev.txt` under certain constraints. The constraint no longer appears to be needed, so all it serves to do now is to cause the docs build to fail on Python 3.9. (cherry picked from commit 0e3716c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original constraint was added in gh-505, at a time when Aer was
specifically requiring jupyter_sphinx in its own
requirements-dev.txtunder certain constraints. The constraint no longer appears to be
needed, so all it serves to do now is to cause the docs build to fail on
Python 3.9.
Details and comments
While Ignis is still in the metapackage, its docs need to be able to build under its constraints. This PR is part of Qiskit/qiskit#1400, updating the dependencies of the docs build, and is effectively the same as Qiskit/qiskit-aer#1429.