Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

874 pre commit hook #875

Merged
merged 3 commits into from
Nov 9, 2022
Merged

874 pre commit hook #875

merged 3 commits into from
Nov 9, 2022

Conversation

cdelnano
Copy link
Collaborator

@cdelnano cdelnano commented Nov 9, 2022

What are the issues this pull addresses (issue numbers / links)?

Issue #874

Did you add tests to cover your changes (yes/no)?

Verified all changes myself.

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

I updated the pre-commit hook to only run on .py files, not .ipynb files. I also updated the qiskit-metal\README_developers.md.

Details and comments

Branch can be deleted after PR is merged.

Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit 39313b1 into main Nov 9, 2022
@priti-ashvin-shah-ibm priti-ashvin-shah-ibm deleted the 874_pre_commit_hook branch November 9, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants