Add MANIFEST.in #895
Merged
Add MANIFEST.in #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a MANIFEST.in file so that some top-level text files make it into the source distribution. requirements.txt and README.md are needed in order to install the package from the source distribution because they are accessed by setup.py. LICENSE.txt is also included because it is best practice to include the license when distributing source code.
|
It might be good to update the release.yml. Invoking |
10 tasks
priti-ashvin-shah-ibm
requested review from
obrienpja and
priti-ashvin-shah-ibm
priti-ashvin-shah-ibm
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
#894
Did you add tests to cover your changes (yes/no)?
No code was changed
Did you update the documentation accordingly (yes/no)?
N/A
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
This adds a MANIFEST.in file so that some top-level text files make it into the source distribution.
Details and comments
requirements.txt and README.md are needed in order to install the package from the source distribution because they are accessed by setup.py. LICENSE.txt is also included because it is best practice to include the license when distributing source code.
Closes #894