Remove deprecation.py #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
requested review from
stefan-woerner and
t-imamichi
as code owners
t-imamichi
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes the deprecation.py that was created some time ago to provide deprecation decorators for the apps. Recently the Qiskit decorators have been overhauled and improved, plus the automatically add deprecation info to the docs. Going forwards the Qiskit decorators should be used for deprecations - Nature even had an issue qiskit-community/qiskit-nature#1196 to switch usage. Given there is no deprecated code here now, so with the module being unused its a good time to remove it - it is being done in Nature here qiskit-community/qiskit-nature#1248 (which removes deprecated code there) which prompted me to do it here.
Since that was just used by developers on the code here, and is not part of public API, no reno is needed.
Details and comments