Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QAOA compatibility with no dependencies from qiskit-algortithms #634

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

TolisChal
Copy link
Collaborator

@TolisChal TolisChal commented Aug 23, 2024

This PR migrates qaoa.py from qiskit-algorithms:

i) It adds qaoa.py and its dependencies from qiskit-algorithms
ii) It adds only the necessary for qaoa dependencies from qiskit-algorithms
iii) It migrates the source code from qiskit-algorithms following the paradigm of this PR: qiskit-community/qiskit-machine-learning#817

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

@TolisChal TolisChal changed the title QAOA compatibility with no dependencies from qiskit-algortithms [Draft] QAOA compatibility with no dependencies from qiskit-algortithms Aug 23, 2024
@t-imamichi
Copy link
Collaborator

Thank you for making this draft.
FYI, Qiskit machine learning also migrated qiskit-algorithms for the same reason. I think their approach would be helpful.
qiskit-community/qiskit-machine-learning#817

@TolisChal TolisChal changed the title [Draft] QAOA compatibility with no dependencies from qiskit-algortithms QAOA compatibility with no dependencies from qiskit-algortithms Aug 27, 2024
@t-imamichi
Copy link
Collaborator

I suggest make copyright to fix all copyright issues.

@coveralls
Copy link

coveralls commented Sep 2, 2024

Pull Request Test Coverage Report for Build 12356789119

Details

  • 1232 of 1380 (89.28%) changed or added relevant lines in 31 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 92.056%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/eigensolvers/eigensolver.py 30 31 96.77%
qiskit_optimization/minimum_eigensolvers/minimum_eigensolver.py 29 30 96.67%
qiskit_optimization/observables_evaluator.py 45 46 97.83%
qiskit_optimization/algorithm_job.py 5 7 71.43%
qiskit_optimization/algorithm_result.py 19 21 90.48%
qiskit_optimization/minimum_eigensolvers/numpy_minimum_eigensolver.py 41 44 93.18%
qiskit_optimization/minimum_eigensolvers/sampling_mes.py 42 46 91.3%
qiskit_optimization/utils/algorithm_globals.py 35 41 85.37%
qiskit_optimization/variational_algorithm.py 59 67 88.06%
qiskit_optimization/optimizers/optimizer.py 162 173 93.64%
Totals Coverage Status
Change from base Build 12327693181: -0.8%
Covered Lines: 5678
Relevant Lines: 6168

💛 - Coveralls

@TolisChal TolisChal requested a review from Dniskk September 26, 2024 14:33
test/test_algorithm_result.py Outdated Show resolved Hide resolved
qiskit_optimization/algorithms/admm_optimizer.py Outdated Show resolved Hide resolved
@TolisChal TolisChal requested a review from thkleinert as a code owner October 25, 2024 12:06
@t-imamichi
Copy link
Collaborator

Could you update readme.md to replace qiskit_algorithms?

@TolisChal
Copy link
Collaborator Author

Could you update readme.md to replace qiskit_algorithms?

Thanks for noticing it. I updated the readme accordingly.

Copy link
Collaborator

@Dniskk Dniskk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants