-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added converter for PlantUML builtin functions #409
base: master
Are you sure you want to change the base?
Conversation
Thanks. Basically, you're going to implement a compatible preprocessor within the extension, which I think it not worthwhile to do it. Here is my tips:
|
Hi, thanks for your valuable tipps. I've done a complete rewrite of the preprocessor based on your tipps. From my point of view nearly all possible preprocessing is done. There is one point left:
Also I've changed the place where I've hooked the preprocessing in. As you mentioned, the preprocessor is called before the Regards Jochen |
7194871
to
4a8cef3
Compare
Hi,
as mentionend and proposed in issue #400 this is a substitution mechanism for your extension. In this pull request there is a very quick and dirty draft version as proof of concept. I'm looking forward to your comments and hopefully your support. I'm not so familiar with reqular expressions in TypeScript and how to pass matches (groups) of the find-part to the replace-part. Also I don't know it the place where I've hooked this in is the right place.
Regards
Jochen