Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support V-USB as a submodule #62

Merged
merged 3 commits into from
May 30, 2020
Merged

Support V-USB as a submodule #62

merged 3 commits into from
May 30, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 7, 2020

This adds the necessary logic to checkout the V-USB Git repo when it becomes a submodule (qmk/qmk_firmware#8321). Probably these will need to be merged in unison.

@fauxpark fauxpark requested review from skullydazed and a team March 7, 2020 17:22
@fauxpark fauxpark mentioned this pull request Mar 7, 2020
@fauxpark fauxpark changed the title Support V-USB as a submodule, and add protocol detection Support V-USB as a submodule Mar 9, 2020
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(__attribute__ ((weak))

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@noroadsleft noroadsleft merged commit 1847c00 into qmk:master May 30, 2020
@fauxpark fauxpark deleted the vusb-checkout-and-protocol-detection branch May 31, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants