Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for intl key legends based on the host keyboard layout #1161
Add support for intl key legends based on the host keyboard layout #1161
Changes from 23 commits
05132fe
685ef10
db0707d
6862ff9
02fb835
c1a24f6
841e991
cde87db
6a75bd7
0e82531
4a6e0e6
fc54838
0a9cb69
af9118a
82cb033
161c40b
ac76998
69e5ad7
f82764c
7a4c67a
b9ac8b2
eaee8fa
414986d
fee4d15
2f5c48a
8cb10a2
bc7b3b3
b31875b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that I'm undoing your work, @yanfali, but in the absence of a ISO toggle in the settings panel, users should still be able to switch keyboard geometries without having to change the selected OS keyboard layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I took it out because it seemed weird to not switch if you selected ISO in the settings panel. Now you've added locale it's more nuanced.