-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for intl key legends based on the host keyboard layout #1161
Merged
Merged
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
05132fe
Create a script to convert keymap_extras/keymap_*.h from qmk_firmware
precondition 685ef10
Generate LUTs for US, UK, RU and DE
precondition db0707d
Export keymap_extras LUTs with metadata
precondition 6862ff9
Add support for intl key legends based on the host keyboard layout
precondition 02fb835
Prettify default quantum keycodes info
precondition c1a24f6
Refactor KC_NUHS/KC_BSLS gen funcs
precondition 841e991
Warn if keysym.length > 3
precondition cde87db
Use intlAlias for title of missing shifted aliases
precondition 6a75bd7
Remove en-UK
precondition 0e82531
Handle KC_PIPE exceptionally in generateMissingShiftedAliasKcInfo
precondition 4a6e0e6
Comment and organise keymap_us.js
precondition fc54838
Locale-aware sort of the OS keyboard layouts by their labels.
precondition 0a9cb69
keycodes/changeKeyLegends → keycodes/updateKeycodeNames and merge
precondition af9118a
Update cypress test to use OS kb layout dropdown instead of ISO toggle
precondition 82cb033
set configSett.osKeyboardLayout = 'keymap_us' if undefined or invalid
precondition 161c40b
Bring back ANSI/ISO buttons on tester page
precondition ac76998
Merge locally stored configuratorSettings with defaults
precondition 69e5ad7
Sort osKeyboardLayouts array alphabetically
precondition f82764c
Sort osKeyboardLayout translatable strings more consistently
precondition 7a4c67a
Translate options to German
precondition b9ac8b2
Use a more formal verb (coller→correspondre)
precondition eaee8fa
Change active keycode picker tab via `changeActive`, not `updateKeyco…
precondition 414986d
Catch promise exceptions when setting lang or OS kb layout
precondition fee4d15
Use string template for osLayout label
precondition 2f5c48a
*Commit* changes to ISO in generateKeycodes
precondition 8cb10a2
Use commit and getters to manipulate OS layout in getOSKeyboardLayout
precondition bc7b3b3
Remove spaces around the '/' of KC_GESC's keycode name
precondition b31875b
Use string template for translatedLayoutName
precondition File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that I'm undoing your work, @yanfali, but in the absence of a ISO toggle in the settings panel, users should still be able to switch keyboard geometries without having to change the selected OS keyboard layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I took it out because it seemed weird to not switch if you selected ISO in the settings panel. Now you've added locale it's more nuanced.