Add more OS keyboard layouts #1165
Conversation
precondition
force-pushed
the
more_os_kb_layouts
branch
from
e341a07 to
2e9572a
Compare
precondition
force-pushed
the
more_os_kb_layouts
branch
from
bcb3699 to
b5fb39c
Compare
This is done so that the Shift+GESC and GUI+GESC keysyms/keycode names remain on the same line because the `breakLines` functions of PrintKey.vue and TesterKey.vue replace spaces ' ' with newlines '\n'
precondition
force-pushed
the
more_os_kb_layouts
branch
from
b5fb39c to
4756c38
Compare
src/store/modules/app/state.js
Outdated
| @@ -79,10 +79,67 @@ const state = { | |||
| { value: 'zh-CN', label: '简体中文' } | |||
| ], | |||
| osKeyboardLayouts: [ | |||
| 'keymap_belgian', | |||
There was a problem hiding this comment.
ok this is long enough now, please extract it to it's own JS file and import it. :)
There was a problem hiding this comment.
Done in commit ffcfc24. Although I'm not sure what's the best directory to put in or what case mode to use for the filename (exclusion_list.js, longFormKeycodes.js, and potato-facts.js all use a different case mode so I don't know what's the desired style for filenames)
There was a problem hiding this comment.
Ideally, we wouldn't even need to maintain a list of OS keyboard layout identifiers and just tell the configurator to list all src/i18n/keymap_extras/keymap_*.js files (and strip the path stem and .js extension) but I don't know what would be an idiomatic way to achieve that.
There was a problem hiding this comment.
Ideally, we wouldn't even need to maintain a list of OS keyboard layout identifiers and just tell the configurator to list all
src/i18n/keymap_extras/keymap_*.jsfiles (and strip the path stem and .js extension) but I don't know what would be an idiomatic way to achieve that.
We would have to do it at build time and write some node js that ran as part of the build and generated the file. There's some precedence for this, i18n and version number of build. This app is serverless, so it doesn't have any file system as such and you can't really glob a file system when you are over a http request. So better to do it at build time.
There was a problem hiding this comment.
Done in commit ffcfc24. Although I'm not sure what's the best directory to put in or what case mode to use for the filename (
exclusion_list.js,longFormKeycodes.js, andpotato-facts.jsall use a different case mode so I don't know what's the desired style for filenames)
if you want to rename all the files to one of the styles for consistency I'd be open to that. I think I'd prefer the snake casing if we were going to pick a style.
|
Bump |
|
This is kind of big. I know it's a lot of configuration. One concern is that it's loading all this stuff into memory. I wonder if we can lazy load this as it's not needed by 90% of users. I'll look at it over the next few days. |
|
Intending to review this Sunday my time. Busy week. |
There was a problem hiding this comment.
What a passion project. Very impressive. As far as I can tell it doesn't seem to impact loading times too much as it's mostly text which should compress well.
I happened to find a feature you might like in the vite docs:
https://vitejs.dev/guide/features.html#glob-import
I think we talked about this once a while back.
|
@noroadsleft give this a once over please. My only usability peccadillo is that the drop down is now huge. But other than that it's a very cool feature. |
It's not only huge, it's also wide – nearly wider than the settings panel itself, at least for me:
|
|
Thanks! |
|
I can look into replacing the drop down with a scrollable dialog box with spoilers for each language. |
|
Nah. It's not a feature anyone will use very frequently. It should be fine.
…On Mon, Sep 19, 2022, 22:45 precondition ***@***.***> wrote:
I can look into replacing the drop down with a scrollable dialog box with
spoilers for each language.
—
Reply to this email directly, view it on GitHub
<#1165 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARLSU6LDMX7NKD635ZCP3LV7FFORANCNFSM57BRFRMA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Description
Generated keycode LUTs for conversion of the configurator front-end from one OS keyboard layout to another with the help of the
convert_keymap_extras_header.jsscript added in #1161.