Stricter conditions on add_oneshot_mods & del_oneshot_mods

Prevent extending the one shot timer if the called add_oneshot_mods or del_oneshot_mods do not change anything to the current one shot mod state. Co-authored-by: David Kosorin <david@kosorin.net>
qmk · Nov 10, 2020 · 87aa23d · 87aa23d
1 parent 6404c29
commit 87aa23d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tmk_core/common/action_util.c b/tmk_core/common/action_util.c
@@ -297,7 +297,7 @@ void clear_macro_mods(void) { macro_mods = 0; }
 uint8_t get_oneshot_mods(void) { return oneshot_mods; }
 
 void add_oneshot_mods(uint8_t mods) {
-    if (oneshot_mods != mods) {
+    if ((oneshot_mods & mods) != mods) {
 #    if (defined(ONESHOT_TIMEOUT) && (ONESHOT_TIMEOUT > 0))
         oneshot_time = timer_read();
 #    endif
@@ -307,7 +307,7 @@ void add_oneshot_mods(uint8_t mods) {
 }
 
 void del_oneshot_mods(uint8_t mods) {
-    if (oneshot_mods) {
+    if (oneshot_mods & mods) {
         oneshot_mods &= ~mods;
 #    if (defined(ONESHOT_TIMEOUT) && (ONESHOT_TIMEOUT > 0))
         oneshot_time = oneshot_mods ? timer_read() : 0;