Skip to content

Commit

Permalink
audio-configuration: fix avr boards with wrong configuration
Browse files Browse the repository at this point in the history
the audiopin with avr boards does not default to anything, if it is not set as a define in config.h, audio output won't work - even worse the compiler will include parts of the audio-system in the firmware, wasting space and possibly failing builds because of the firmware exceeding the maximum size
  • Loading branch information
Johannes committed May 7, 2020
1 parent ced4a64 commit 8b3b406
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion keyboards/subatomic/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ COMMAND_ENABLE = no # Commands for debug and configuration
NKRO_ENABLE = no # Nkey Rollover - if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work
BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality
MIDI_ENABLE = yes # MIDI controls
AUDIO_ENABLE = yes # Audio output on port C6
AUDIO_ENABLE = no # Audio output (needs a pin configured in config.h, see docs/feature_audio.md)
UNICODE_ENABLE = no # Unicode
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight.
Expand Down
2 changes: 1 addition & 1 deletion keyboards/vision_division/keymaps/default/rules.mk
Original file line number Diff line number Diff line change
@@ -1 +1 @@
AUDIO_ENABLE = yes
AUDIO_ENABLE = no # Audio output (needs a pin configured in config.h, see docs/feature_audio.md)
2 changes: 1 addition & 1 deletion keyboards/vision_division/rules.mk
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by d
MIDI_ENABLE = no # MIDI controls
UNICODE_ENABLE = no # Unicode
BLUETOOTH_ENABLE = no # Enable Bluetooth with the Adafruit EZ-Key HID
AUDIO_ENABLE = no # Audio output on port C6
AUDIO_ENABLE = no # Audio output (needs a pin configured in config.h, see docs/feature_audio.md)

0 comments on commit 8b3b406

Please sign in to comment.