Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Massdrop CTRL Endgame - Build Error 'undefined reference to g_suspend_state' #13782

Closed
SmokeMonsterPacks opened this issue Jul 30, 2021 · 2 comments · Fixed by #13805
Closed

[Bug] Massdrop CTRL Endgame - Build Error 'undefined reference to g_suspend_state' #13782

SmokeMonsterPacks opened this issue Jul 30, 2021 · 2 comments · Fixed by #13805
Labels
bug help wanted

Comments

@SmokeMonsterPacks
Copy link

SmokeMonsterPacks commented Jul 30, 2021 •
edited
Loading

Describe the Bug

Massdrop CTRL Endgame: Firmware building fails with the error 'undefined reference to g_suspend_state'

It can be resolved by deleting the reference to g_suspend_state from keymap.c and keymap.h in the Endgame files

It looks like it might be related to this (May 21 breaking changes): https://github.com/qmk/qmk_firmware/commit/1646c0f26cfa21a7023d404008e4d0aa4917193d
One of the changes mentions USB Suspend changes, which points to this pull request: https://github.com/qmk/qmk_firmware/pull/12697/files

System Information

  • Keyboard:
    • Massdrop CTRL

Additional Context

The error was confirmed by two other users helping me:
1unknown
2image0
@tzarc
Copy link
Member

tzarc commented Jul 30, 2021

Our develop-targeting CI doesn't build any keymaps other than default or via, so this wasn't going to get picked up unless someone explicitly built it.

Feel free to make a PR if what you've done fixes it.

@SmokeMonsterPacks
Copy link
Author

SmokeMonsterPacks commented Jul 30, 2021 •
edited
Loading

I'm afraid to mess something up with a PR, but here are the two fixed files if someone could please pull them in?
Fixed Keymaps - Massdrop CTRL Endgame.zip

I've simply removed the two references to g_suspend_state
unknown

Slashbunny added a commit to Slashbunny/qmk_firmware that referenced this issue Jul 30, 2021
@Slashbunny
Update endgame keymap to work with suspend changes
166aea2 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
@Slashbunny Slashbunny mentioned this issue Jul 30, 2021
Merged
14 tasks
zvecr pushed a commit that referenced this issue Jul 31, 2021
@Slashbunny
Update endgame keymap to work with suspend changes (#13805)
3f5482b 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in #12697

Fixes #13782
CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this issue Aug 8, 2021
@Slashbunny
Update endgame keymap to work with suspend changes (qmk#13805)
c5144cd 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this issue Aug 28, 2021
@Slashbunny
Update endgame keymap to work with suspend changes (qmk#13805)
415b138 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
asaph added a commit to asaph/qmk_firmware that referenced this issue Nov 16, 2021
@asaph
Fix for matthewrobo keymap compilation error
eb0a273 
This was the same issue as seen in the endgame keymap.

References:
Same issue in endgame keymap: qmk#13782
Fix in endgame keymap: qmk@3f5482b
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this issue Dec 5, 2021
@Slashbunny @nhongooi
Update endgame keymap to work with suspend changes (qmk#13805)
917e954 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
ifonefox added a commit to ifonefox/qmk_firmware that referenced this issue Jan 21, 2022
@ifonefox
Disabled eeprom save/load and fixed compile issue
2722b9b 
See qmk#13782 and qmk#12697 for info on compile issuee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update endgame keymap to work with suspend changes Slashbunny/qmk_firmware
2 participants
@tzarc @SmokeMonsterPacks