Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the amazing new Tap Dance feature #455

Closed
ezuk opened this issue Jun 29, 2016 · 10 comments
Closed

Document the amazing new Tap Dance feature #455

ezuk opened this issue Jun 29, 2016 · 10 comments
Assignees

Comments

@ezuk
Copy link
Contributor

ezuk commented Jun 29, 2016

So we now have @algernon's awesome Tap Dance feature merged in!

I need to document the feature and show an example of how it's used.

@ezuk ezuk self-assigned this Jun 29, 2016
@squarology
Copy link

Hi, @ezuk, I'm not trying to rush you in any way, I'm just curious how much progress you've made with some documentation and an example or two. Thanks.

@algernon
Copy link
Contributor

algernon commented Jul 7, 2016

The original pull request, #451 has some examples, simple ones. Those are a reasonable start until better docs are available.

@ezuk
Copy link
Contributor Author

ezuk commented Jul 9, 2016

@squarology I actually appreciate the ping. I've now simply taken @algernon's excellent documentation from the PR, credited him, and put it right in the official readme. Please let me know if there are any edits, tweaks, or examples you'd like to make.

@squarology
Copy link

Is it possible to have a tap dance key do one thing when it's unshifted and another thing when it is shifted?

@algernon
Copy link
Contributor

@squarology yes, but not easily. You will have to use a custom function, with the ACTION_TAP_DANCE_FN helper, and you can check whether shift is set there, and register a keycode accordingly.

@piotr-dobrogost
Copy link

piotr-dobrogost commented Jul 20, 2016

Having double tap a key act like tapping the key with AltGr pressed could be a nice feature for those having to use AltGr to insert characters with diacritical marks or other special ones. This is particularly since very often right Alt is mapped to AltGr, making it difficult to type many combos employing Alt key.

@algernon
Copy link
Contributor

@piotr-dobrogost working on something like that. I have something that works sometimes, when one modifier is pressed, but it's not done yet.

The goal is to allow ACTION_TAP_DANCE_DOUBLE(KC_A, RALT(KC_A)) to do the right thing, and register RALT + A when double tapped.

Converting QMK modifiers to TMK codes to pass along to register_code is not as trivial as I would have hoped.

@moonrumble
Copy link

@algernon It is the right thing to do. I would expect register_code method to take all the combination that i can use directly keymaps directly.

@algernon
Copy link
Contributor

algernon commented Sep 8, 2016

I think this can be closed now, there is adequate documentation, with examples, in the readme now.

@ezuk
Copy link
Contributor Author

ezuk commented Sep 10, 2016

Agreed! Thank you @algernon!

@ezuk ezuk closed this as completed Sep 10, 2016
BlueTufa pushed a commit to BlueTufa/qmk_firmware that referenced this issue Aug 6, 2021
- update yarn.lock to remove bad lodash refs
 - update prettier
 - add missing eslint-plugin-prettier dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants