Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Console Descriptor shoud be one way #8593

Closed
3 tasks
yiancar opened this issue Mar 28, 2020 · 2 comments
Closed
3 tasks

[Bug] Console Descriptor shoud be one way #8593

yiancar opened this issue Mar 28, 2020 · 2 comments
Assignees

Comments

@yiancar
Copy link
Contributor

yiancar commented Mar 28, 2020

Describe the Bug

Looking at the console descriptor it has both an input and output section.
This is probably because of the rawhid code from PJRC. In my understanding we use console as a one way communication tool. From the keyboard TO the host. If this is true, and if qmk-toolbox is only listening, I suggest we modify the descriptors to show that only output exists.

In a quick look it looks like console code does not handle any input anyway, please correct me if I am wrong

System Information

  • Keyboard:
    • Revision (if applicable):
  • Operating system:
  • AVR GCC version:
  • ARM GCC version:
  • QMK Firmware version:
  • Any keyboard related software installed?
    • AutoHotKey
    • Karabiner
    • Other:

Additional Context

@yiancar
Copy link
Contributor Author

yiancar commented Mar 29, 2020

Ok initial check:
yiancar@4ecea11

Chibios:
Removed the output hid descriptor, removed the input handling. All good.
Trying to remove the endpoint is not as straight forward.

Removing CONSOLE_IN_EPNUM starts to cause issue as in usb_main.c the macro QMK_USB_DRIVER_CONFIG need the epnum. Furthermore out_ep_config is always in the macro. Any ideas how to exclude it without making everything ugly?

@drashna
Copy link
Member

drashna commented Oct 13, 2024

This was fixed in 22304.

@drashna drashna closed this as completed Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants