Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove console out endpoint #22304

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Remove console out endpoint #22304

merged 2 commits into from
Jan 9, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 21, 2023 •
edited
Loading

Description

ChibiOS changes a bit gross as QMK_USB_DRIVER_CONFIG and the various driver code assumes both endpoints and unpicking it is much more of a change. Instead the vusb implementation was cribbed.

Tested on:

  • chibios - drop/alt/v2 + zvecr/zv48/f401
  • lufa - drop/thekey/v2
  • vusb - jj4x4
  • arm_atsam - compiles but ignored due to pending removal.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 21, 2023
@zvecr zvecr marked this pull request as ready for review October 21, 2023 19:57
@zvecr zvecr marked this pull request as draft October 21, 2023 20:12
@zvecr zvecr marked this pull request as ready for review October 22, 2023 15:31
@zvecr

This comment was marked as outdated.

Sign in to view
@zvecr zvecr closed this Nov 2, 2023
@zvecr zvecr reopened this Nov 2, 2023
@zvecr zvecr mentioned this pull request Dec 23, 2023
Merged
16 tasks
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 30, 2023
@zvecr zvecr added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Dec 30, 2023
@tzarc tzarc requested a review from a team January 9, 2024 11:36
@zvecr zvecr merged commit b6b3efc into develop Jan 9, 2024
7 checks passed
@zvecr zvecr deleted the console_rm_out branch January 9, 2024 14:01
@KarlK90 KarlK90 mentioned this pull request Jan 14, 2024
Merged
14 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Remove console out endpoint (qmk#22304)
303b110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
awaiting review core optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc