Allow backlight duty cycle limit #10260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
force-pushed
the
backlight-duty-cycle-limit
branch
from
f8fd4a2 to
cad9eaf
Compare
|
Pending other backlight drivers, documentation. |
noroadsleft
force-pushed
the
develop
branch
from
a1b96ba to
3430907
Compare
tzarc
force-pushed
the
backlight-duty-cycle-limit
branch
from
8d1b858 to
38fb196
Compare
tzarc
added
hacktoberfest-accepted
drashna
approved these changes
Oct 7, 2020
tzarc
force-pushed
the
backlight-duty-cycle-limit
branch
from
734afad to
8d7d959
Compare
tzarc
force-pushed
the
backlight-duty-cycle-limit
branch
from
8d7d959 to
12cefd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needed to be able to apply a limit to the backlighting duty cycle -- breadboard testing of using QMK's backlight code to control an LCD backlight showed it was pulling 80mA, but in circuit with SMT components it showed it was capable of pulling 400mA per LCD.
Artificially limiting the duty cycle allows controlling max brightness instead of messing about with current limiting circuits, much like the RGB limit constants we already have.
Types of Changes
Checklist