[Keymap] Added 5x6_5 keymap #10272

333fred · 2020-09-09T07:39:34Z

Description

I have a new keyboard, so as usual I'm upstreaming the keymap I created for it. I have some LCD screens on this board, so I added a quote displayer for a few quotes from books in The Stormlight Archive and The Wheel of Time.

Types of Changes

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

333fred · 2020-09-10T06:46:44Z

Some updates from a day of usage:

I wanted to make sure that my random quote display mechanism wasn't waking the display up every 5 minutes, so I added a small utility function to the OLED driver to tell if the display is on. I also updated the docs to include it, please let me know if there is anywhere else I should add it to.
I've filled my keyboard with as many random quotes from The Stormlight Archive and The Wheel of Time as I could fit. I currently have 6 bytes free, so if we could just never add features that take more memory again that would be fantastic... 😅

drashna

Could the oled code be pulled out into a separate PR?

users/333fred/333fred.h

users/333fred/rules.mk

keyboards/handwired/dactyl_manuform/5x6_5/keymaps/333fred/keymap.c

333fred · 2020-09-21T03:54:40Z

Rebased this PR to put the oled change first. When #10382 is merged, I can rebase this PR on top of master and drop that commit.

drashna · 2020-09-22T06:50:41Z

Is merged, so rebase away!

…a stormlight quote randomizer.

* Turn off WPM. It's too inaccurate and takes up a decent amount of space that can be devoted to quotes. * Turn off the OLEDs after 5 minutes * Move the keys around a bit. * Add many more quotes.

… Adjusted the keymap slightly. Adjust the mods display to include one_shots.

333fred · 2020-09-22T18:28:15Z

Done, thanks!

keyboards/handwired/dactyl_manuform/5x6_5/keymaps/333fred/config.h

keyboards/handwired/dactyl_manuform/5x6_5/keymaps/333fred/keymap.c

333fred · 2020-09-24T04:58:02Z

@noroadsleft what are the options? I generally tend to prefer licenses like MIT or BSD-3, but I'm not sure how that squares with the rest of the QMK repo itself, as it's GPL

noroadsleft · 2020-09-24T07:30:20Z

what are the options? I generally tend to prefer licenses like MIT or BSD-3, but I'm not sure how that squares with the rest of the QMK repo itself, as it's GPL

My understanding of this from recent conversations is that both MIT and BSD-3 are compatible with GPL2 distribution.

333fred · 2020-10-01T04:00:17Z

@noroadsleft sorry for the delay. I wanted to get all my keymaps at once.

users/333fred/rgb.c

Co-authored-by: Ryan <fauxpark@gmail.com>

layouts/community/ergodox/333fred/keymap.c

users/333fred/333fred.c

drashna · 2020-10-04T15:54:35Z

users/333fred/rules.mk

@@ -7,3 +7,4 @@ endif
 TAP_DANCE_ENABLE=yes
 NKRO_ENABLE = yes
 PERMISSIVE_HOLD = yes
+LTO_ENABLE = yes


You may not want this applying to everything, as it can cause issues on ChibiOS (ARM). Though, that may not be an issue for you, at least, as of yet.

* 'master' of https://github.com/qmk/qmk_firmware: (178 commits) Docs: fix udev rules [CLI] Add c2json (qmk#8817) Improve LAYOUT macro searching (qmk#9530) CLI: update subcommands to use return instead of exit() (qmk#10323) Fixes small typo in docs (qmk#10515) Update personal keymap for Let's Split keyboard. (qmk#10536) [Keymap] Move my custom functions and keymaps to userspace (qmk#10502) [Keyboard] add support for ymd75 rev3 (qmk#10483) [Keyboard] Add soy20 PCB (qmk#10440) Fix for MIDI sustain effect issue (qmk#10361) format code according to conventions [skip ci] [Keyboard] Add Yugo-M Controller (qmk#10389) [Keymap] Add onekey keymap for OLED testing (qmk#10380) [Keymap] Add winterNebs keymaps (qmk#10328) [Keymap] Added 333fred 5x6_5 keymap (qmk#10272) [Keyboard] Add hannah60rgb rev.2 PCB (qmk#10287) Adding VIA support to katana60 rev2 (qmk#10442) OLED driver fixes (qmk#10377) IS31FL3741 driver fixup (qmk#10519) add info.json for XD75 keyboard (qmk#10523) ...

* First pass at manuform layout. * Updates from actual usage on my board. Fixed a couple of bugs, added a stormlight quote randomizer. * Use a 32-bit timer that can actually hit 5 minutes. * Some updates after a day of usage: * Turn off WPM. It's too inaccurate and takes up a decent amount of space that can be devoted to quotes. * Turn off the OLEDs after 5 minutes * Move the keys around a bit. * Add many more quotes. * Adjust the quotes to make room for missing and misswritten WoT quote. Adjusted the keymap slightly. Adjust the mods display to include one_shots. * Revert osm on lgui as it makes start menu search impossible to use. * Use LTO_ENABLE flag. * License all of my (333fred's) keymaps as MIT. * Update users/333fred/rgb.c Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>

333fred force-pushed the manuform branch from 0638a46 to b97d31a Compare September 9, 2020 08:03

drashna requested changes Sep 21, 2020

View reviewed changes

users/333fred/333fred.h Show resolved Hide resolved

users/333fred/rules.mk Outdated Show resolved Hide resolved

keyboards/handwired/dactyl_manuform/5x6_5/keymaps/333fred/keymap.c Show resolved Hide resolved

drashna requested a review from a team September 21, 2020 03:36

drashna added the keymap label Sep 21, 2020

333fred mentioned this pull request Sep 21, 2020

Add function to determine if the OLED is on #10382

Merged

333fred force-pushed the manuform branch from c48c115 to a5f11ed Compare September 21, 2020 03:54

333fred added 7 commits September 22, 2020 11:27

First pass at manuform layout.

afc11eb

Updates from actual usage on my board. Fixed a couple of bugs, added …

1607cc4

…a stormlight quote randomizer.

Use a 32-bit timer that can actually hit 5 minutes.

bfb2733

Some updates after a day of usage:

339c905

* Turn off WPM. It's too inaccurate and takes up a decent amount of space that can be devoted to quotes. * Turn off the OLEDs after 5 minutes * Move the keys around a bit. * Add many more quotes.

Adjust the quotes to make room for missing and misswritten WoT quote.…

d63bd36

… Adjusted the keymap slightly. Adjust the mods display to include one_shots.

Revert osm on lgui as it makes start menu search impossible to use.

2bdacf1

Use LTO_ENABLE flag.

d3582bd

333fred force-pushed the manuform branch from a5f11ed to d3582bd Compare September 22, 2020 18:27

noroadsleft requested changes Sep 23, 2020

View reviewed changes

keyboards/handwired/dactyl_manuform/5x6_5/keymaps/333fred/config.h Show resolved Hide resolved

keyboards/handwired/dactyl_manuform/5x6_5/keymaps/333fred/keymap.c Show resolved Hide resolved

License all of my (333fred's) keymaps as MIT.

0b161fb

fauxpark requested changes Oct 1, 2020

View reviewed changes

users/333fred/rgb.c Outdated Show resolved Hide resolved

Update users/333fred/rgb.c

dbb6511

Co-authored-by: Ryan <fauxpark@gmail.com>

Erovia reviewed Oct 1, 2020

View reviewed changes

layouts/community/ergodox/333fred/keymap.c Show resolved Hide resolved

users/333fred/333fred.c Show resolved Hide resolved

Erovia requested review from drashna, noroadsleft and fauxpark October 1, 2020 18:36

Erovia approved these changes Oct 1, 2020

View reviewed changes

Erovia requested a review from a team October 1, 2020 21:20

drashna reviewed Oct 4, 2020

View reviewed changes

drashna approved these changes Oct 4, 2020

View reviewed changes

drashna merged commit 1aacbc4 into qmk:master Oct 4, 2020

333fred deleted the manuform branch October 4, 2020 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keymap] Added 5x6_5 keymap #10272

[Keymap] Added 5x6_5 keymap #10272

333fred commented Sep 9, 2020 •

edited

Loading

333fred commented Sep 10, 2020

drashna left a comment

333fred commented Sep 21, 2020

drashna commented Sep 22, 2020

333fred commented Sep 22, 2020

333fred commented Sep 24, 2020

noroadsleft commented Sep 24, 2020

333fred commented Oct 1, 2020

drashna Oct 4, 2020

[Keymap] Added 5x6_5 keymap #10272

[Keymap] Added 5x6_5 keymap #10272

Conversation

333fred commented Sep 9, 2020 • edited Loading

Description

Types of Changes

Checklist

333fred commented Sep 10, 2020

drashna left a comment

Choose a reason for hiding this comment

333fred commented Sep 21, 2020

drashna commented Sep 22, 2020

333fred commented Sep 22, 2020

333fred commented Sep 24, 2020

noroadsleft commented Sep 24, 2020

333fred commented Oct 1, 2020

drashna Oct 4, 2020

Choose a reason for hiding this comment

333fred commented Sep 9, 2020 •

edited

Loading