Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swap hands config for kyria #10397

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Add swap hands config for kyria #10397

merged 2 commits into from
Sep 23, 2020

Conversation

winterNebs
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@winterNebs winterNebs mentioned this pull request Sep 22, 2020
Merged
14 tasks
zvecr
zvecr requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the root level config.h doesnt have matrix info, the swap hands config should be moved to keyboards/kyria/rev1/rev1.c so that if a ver2 is introduced with a different matrix size it doesnt cause any issues.

@zvecr zvecr added the keyboard label Sep 22, 2020
@zvecr zvecr changed the title add swap hands config Add swap hands config for kyria Sep 22, 2020
@zvecr zvecr requested a review from a team September 22, 2020 23:13
@zvecr zvecr merged commit afb9179 into qmk:master Sep 23, 2020
@zvecr
Copy link
Member

zvecr commented Sep 23, 2020

Thanks!

@winterNebs winterNebs deleted the kyria_swap branch September 23, 2020 00:35
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@winterNebs @rgoulter
Add swap hands config for kyria (qmk#10397)
04d442d 
* add swap hands config

* move to rev1
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@winterNebs
Add swap hands config for kyria (qmk#10397)
4bc300f 
* add swap hands config

* move to rev1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winterNebs @zvecr @fauxpark