Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Slice RGB VIA Support #10407

Merged
merged 6 commits into from
Oct 2, 2020
Merged

Add Slice RGB VIA Support #10407

merged 6 commits into from
Oct 2, 2020

Conversation

2Moons-JP
Copy link
Contributor

@2Moons-JP 2Moons-JP commented Sep 23, 2020 •
edited
Loading

Add Slice RGB Via Support

Description

Add Slice RGB VIA Support. Clean PR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@2Moons-JP 2Moons-JP mentioned this pull request Sep 24, 2020
Merged
6 tasks
@2Moons-JP
Delete config.h
ff59a3d 
I don't think config here is necessary.
@2Moons-JP
Update keymap.c
e779817 
Keymap Update
@2Moons-JP
Update keymap.c
6cc3108 
Keymap Update2
@2Moons-JP 2Moons-JP requested a review from drashna September 30, 2020 09:02
@fauxpark fauxpark added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Oct 1, 2020
@fauxpark fauxpark requested a review from a team October 1, 2020 17:49
@Erovia Erovia requested a review from a team October 1, 2020 18:02
@2Moons-JP @Erovia
Update keyboards/basekeys/slice/rev1_rgb/keymaps/via/rules.mk
79bb416 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@2Moons-JP 2Moons-JP requested review from Erovia and removed request for a team October 1, 2020 22:25
@Erovia Erovia merged commit 9395a87 into qmk:master Oct 2, 2020
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@2Moons-JP @Erovia @rgoulter
Add Slice RGB VIA Support (qmk#10407)
98ea020 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@2Moons-JP @Erovia
Add Slice RGB VIA Support (qmk#10407)
5285987 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@2Moons-JP @Erovia
Add Slice RGB VIA Support (qmk#10407)
28265cd 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2Moons-JP @drashna @Erovia @fauxpark