Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smk65/revf support #10434

Merged
merged 10 commits into from
Oct 8, 2020
Merged

Add smk65/revf support #10434

merged 10 commits into from
Oct 8, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 24, 2020 •
edited
Loading

Description

  • Assumed master (and backwards compatible) for now
  • Minimal changes to existing rev code
  • Added community support
  • Alignment to current standards where possible

Note: The revF board I have for testing, has no RGB at all so I have left that as a TODO for someone that does.

Questions up for discussion...

  • Should we split out revA, which would modify revB futher, without having hardware to test against?
  • Should we target develop and just migrate action macros?
  • Some revA/B keyboards do not have RGB enabled. Keeping the root level keymaps folder to maintain backwards compatibility causes potential issues on enabling those features by default (settings were already all over the place anyway). Should we default to off to bodge round?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the keyboard label Sep 24, 2020
@zvecr zvecr requested a review from a team September 24, 2020 23:29
@zvecr zvecr marked this pull request as ready for review October 5, 2020 00:22
@zvecr zvecr added the via Adds via keymap and/or updates keyboard for via support label Oct 5, 2020
@tzarc tzarc requested a review from a team October 5, 2020 01:06
fauxpark
fauxpark requested changes Oct 7, 2020
View reviewed changes
keyboards/lfkeyboards/smk65/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/lfkeyboards/smk65/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/lfkeyboards/smk65/keymaps/iso/rules.mk Outdated Show resolved Hide resolved
keyboards/lfkeyboards/smk65/revb/rules.mk Outdated Show resolved Hide resolved
@zvecr @fauxpark
Apply suggestions from code review
82a9de5 
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can get rid of the kb.h stuff and cbi/sbi, otherwise LGTM

@zvecr zvecr merged commit ff1b625 into qmk:master Oct 8, 2020
@zvecr zvecr mentioned this pull request Oct 9, 2020
Merged
6 tasks
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@zvecr @fauxpark
Add smk65/revf support (qmk#10434)
d8bdeff 
* Move existing files out the way

* Convert to community layouts

* Add smk65/revf support

* Disable stuff by default

* Update IDs for via

* Align LAYOUT macros for community layouts

* Align LAYOUT macros for community layouts - Fix configurator ordering

* Update via keymap

* remove stub _kb function

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
@zvecr @fauxpark
Add smk65/revf support (qmk#10434)
5a11b80 
* Move existing files out the way

* Convert to community layouts

* Add smk65/revf support

* Disable stuff by default

* Update IDs for via

* Align LAYOUT macros for community layouts

* Align LAYOUT macros for community layouts - Fix configurator ordering

* Update via keymap

* remove stub _kb function

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark