Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BM60RGB ISO: update default keymap and layout macro #10494

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

noroadsleft
Copy link
Member

Description

  • correctly assigns the Non-US Backslash and Hash keys
  • adds Function and Navigation keys
  • use KC_GESC instead of KC_ESC to make Grave accent available

The layout is the ISO equivalent of QMK's LAYOUT_60_ansi_arrow, so I updated the layout macro, with an alias for backwards compatibility.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have updated the documentation accordingly.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- correctly assigns the Non-US Backslash and Hash keys
- adds Function and Navigation keys
- use KC_GESC instead of KC_ESC to make Grave accent available
The layout is the ISO equivalent of QMK's `LAYOUT_60_ansi_arrow`.
@zvecr zvecr merged commit 1d7e57a into qmk:master Oct 1, 2020
@noroadsleft noroadsleft deleted the fix/bm60rgb_iso branch October 2, 2020 01:53
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
* BM60RGB ISO: fix and extend default keymap

- correctly assigns the Non-US Backslash and Hash keys
- adds Function and Navigation keys
- use KC_GESC instead of KC_ESC to make Grave accent available

* Update layout macro

The layout is the ISO equivalent of QMK's `LAYOUT_60_ansi_arrow`.
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* BM60RGB ISO: fix and extend default keymap

- correctly assigns the Non-US Backslash and Hash keys
- adds Function and Navigation keys
- use KC_GESC instead of KC_ESC to make Grave accent available

* Update layout macro

The layout is the ISO equivalent of QMK's `LAYOUT_60_ansi_arrow`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants