Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port mechmini v2 for VIA support #10497

Merged
merged 6 commits into from
Oct 1, 2020
Merged

Port mechmini v2 for VIA support #10497

merged 6 commits into from
Oct 1, 2020

Conversation

jordandoan
Copy link
Contributor

@jordandoan jordandoan commented Oct 1, 2020 •
edited
Loading

Description

Created VIA keymap for mechmini v2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jordandoan jordandoan mentioned this pull request Oct 1, 2020
Merged
6 tasks
fauxpark
fauxpark approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot on the config.h too 👍

@fauxpark fauxpark added keymap via Adds via keymap and/or updates keyboard for via support labels Oct 1, 2020
@fauxpark fauxpark requested a review from a team October 1, 2020 16:59
Erovia
Erovia reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a thought/preference, not a blocker if you'd leave it as is.
The code looks good/mergeable.

keyboards/mechmini/v2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mechmini/v2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mechmini/v2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mechmini/v2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/mechmini/v2/keymaps/via/keymap.c Outdated Show resolved Hide resolved
jordandoan and others added 5 commits October 1, 2020 13:57
@jordandoan @Erovia
Update keyboards/mechmini/v2/keymaps/via/keymap.c
a29205e 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@jordandoan @Erovia
Update keyboards/mechmini/v2/keymaps/via/keymap.c
cd129fe 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@jordandoan @Erovia
Update keyboards/mechmini/v2/keymaps/via/keymap.c
bd8db9d 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@jordandoan @Erovia
Update keyboards/mechmini/v2/keymaps/via/keymap.c
acf942b 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@jordandoan @Erovia
Update keyboards/mechmini/v2/keymaps/via/keymap.c
88b50c7 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
@Erovia Erovia merged commit f63a60a into qmk:master Oct 1, 2020
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@jordandoan @Erovia @rgoulter
Port mechmini v2 for VIA support (qmk#10497)
3e0a77a 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@jordandoan @Erovia
Port mechmini v2 for VIA support (qmk#10497)
1ac120c 
Co-authored-by: Erovia <Erovia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordandoan @Erovia @fauxpark