Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add niu mini dye sub keymap #10525

Merged
merged 7 commits into from
Oct 7, 2020
Merged

Conversation

chusjp
Copy link
Contributor

@chusjp chusjp commented Oct 3, 2020

Description

This PR is for adding a layout that I was missing in this repo and that has been really useful to me and I think it would be for people having the same keycaps set.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/niu_mini/keymaps/dyesub/keymap.c Outdated Show resolved Hide resolved
keyboards/niu_mini/keymaps/dyesub/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team October 4, 2020 00:16
@zvecr zvecr added the keymap label Oct 4, 2020
chusjp and others added 3 commits October 4, 2020 13:10
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@Erovia Erovia requested review from a team and zvecr October 4, 2020 11:21
@drashna
Copy link
Member

drashna commented Oct 7, 2020

Thanks!

@drashna drashna merged commit cba4c1d into qmk:master Oct 7, 2020
barrettclark pushed a commit to barrettclark/qmk_firmware that referenced this pull request Oct 8, 2020
* upstream/master: (81 commits)
  [Keyboard] New keyboard - eiri (qmk#10529)
  [Keymap] Add niu mini dye sub keymap (qmk#10525)
  Clean ChibiOS platform files (qmk#10505)
  [Keyboard] LeftyNumpad Keyboard (qmk#10500)
  [Keyboard] add maja capslock indicator (qmk#10151)
  Fix issue introduced by PR#10404 (qmk#10559)
  Docs: fix udev rules
  [CLI] Add c2json (qmk#8817)
  Improve LAYOUT macro searching (qmk#9530)
  CLI: update subcommands to use return instead of exit() (qmk#10323)
  Fixes small typo in docs (qmk#10515)
  Update personal keymap for Let's Split keyboard. (qmk#10536)
  [Keymap] Move my custom functions and keymaps to userspace (qmk#10502)
  [Keyboard] add support for ymd75 rev3 (qmk#10483)
  [Keyboard] Add soy20 PCB (qmk#10440)
  Fix for MIDI sustain effect issue (qmk#10361)
  format code according to conventions [skip ci]
  [Keyboard] Add Yugo-M Controller (qmk#10389)
  [Keymap] Add onekey keymap for OLED testing (qmk#10380)
  [Keymap] Add winterNebs keymaps  (qmk#10328)
  ...
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Add niu mini dye sub keymap

* Fix spacing

* Fix for blank spacing on layout

* Remove unused code

Co-authored-by: Joel Challis <git@zvecr.com>

* Remove audio and console settings

Co-authored-by: Joel Challis <git@zvecr.com>

* Updates rules and readme

* Add license GPL2 to keymap

Co-authored-by: Joel Challis <git@zvecr.com>
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
* Add niu mini dye sub keymap

* Fix spacing

* Fix for blank spacing on layout

* Remove unused code

Co-authored-by: Joel Challis <git@zvecr.com>

* Remove audio and console settings

Co-authored-by: Joel Challis <git@zvecr.com>

* Updates rules and readme

* Add license GPL2 to keymap

Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants