Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CLI logfile handling #10535

Closed
wants to merge 1 commit into from
Closed

Fix: CLI logfile handling #10535

wants to merge 1 commit into from

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Oct 4, 2020 •
edited
Loading

Description

Needs #10537 to be merged first.
This will fix the logfile handling.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Erovia Erovia requested a review from a team October 4, 2020 14:28
@Erovia Erovia added cli qmk cli command enhancement python labels Oct 4, 2020
@Erovia Erovia mentioned this pull request Oct 4, 2020
Closed
fauxpark
fauxpark reviewed Oct 4, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to still be ignored by qmk info.

@fauxpark fauxpark requested a review from skullydazed October 4, 2020 15:00
@Erovia
Complimentary change for 10537
81c2966 
Fix logfile handling.
@Erovia Erovia changed the title Fix: proper handling of '--no-color' Fix: CLI logfile handling Oct 5, 2020
@Erovia Erovia requested review from fauxpark, zvecr and a team October 5, 2020 22:18
@Erovia Erovia closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed Awaiting requested review from skullydazed

@fauxpark fauxpark Awaiting requested review from fauxpark

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Erovia @fauxpark @zvecr