-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configurator layout helix/rev3_4rows #10618
Merged
fauxpark
merged 8 commits into
qmk:master
from
yushakobo:fix_configurator_layout_helix_rev3_4rows
Oct 12, 2020
Merged
Fix configurator layout helix/rev3_4rows #10618
fauxpark
merged 8 commits into
qmk:master
from
yushakobo:fix_configurator_layout_helix_rev3_4rows
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick7 readme update
mtei
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The result of qmk info -kb helix/rev3_4rows -km default -m
is now correct.
fauxpark
approved these changes
Oct 12, 2020
Thanks! |
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
Co-authored-by: keyaki-namiki <28521374+keyaki-namiki@users.noreply.github.com>
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
Co-authored-by: keyaki-namiki <28521374+keyaki-namiki@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the layout of
helix/rev3_4rows
was broken in qmk configurator.Types of Changes
Issues Fixed or Closed by This PR
Checklist