Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Keymap for Idobo Keyboard #10783

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Conversation

egstad
Copy link
Contributor

@egstad egstad commented Oct 28, 2020

Description

Adds new keymap/layout/userspace for Idobo keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

keyboards/idobo/keymaps/egstad/config.h Show resolved Hide resolved
keyboards/idobo/keymaps/egstad/keymap.c Show resolved Hide resolved
keyboards/idobo/keymaps/egstad/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team October 29, 2020 07:51
@egstad egstad requested review from drashna and removed request for a team October 29, 2020 18:00
keyboards/idobo/keymaps/egstad/keymap.c Outdated Show resolved Hide resolved
keyboards/idobo/keymaps/egstad/keymap.c Outdated Show resolved Hide resolved
keyboards/idobo/keymaps/egstad/keymap.c Outdated Show resolved Hide resolved
keyboards/idobo/keymaps/egstad/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team October 30, 2020 01:14
@egstad egstad requested review from zvecr and removed request for a team October 31, 2020 22:53
@egstad egstad requested a review from drashna November 1, 2020 22:53
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment on lines +9 to +17
## Keeping up to date
To update your fork’s master, run the following, hitting the Enter key after each line:

```bash
git checkout master
git fetch upstream
git pull upstream master
git push origin master
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @noroadsleft!

@noroadsleft noroadsleft merged commit 84ca67f into qmk:master Nov 9, 2020
@noroadsleft
Copy link
Member

Thanks!

ChrissiQ pushed a commit to ChrissiQ/qmk_firmware that referenced this pull request Nov 10, 2020
* feat: new keymapping for idobo

* fix: added licenses. converted int to uint8_t where applicable

* fix: addressed zvecr stylistic enhancements

* fix: replaced rgblight_sethsv with rgblight_sethsv_noeeprom
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Nov 14, 2020
* upstream/master: (48 commits)
  [Keymap] idobo:egstad (qmk#10783)
  Adding few Korean translated files (qmk#5895)
  [Keyboard] Keebwerk MEGA Initial commit (qmk#10777)
  Indicator LEDs as config (qmk#10816)
  add missing physical layout options and VIA support for Sesame (qmk#10471)
  [Keyboard] Fix unused variables in mschwingen modelm (qmk#10811)
  Add big spacebar defaults to Underscore33 (qmk#10731)
  Add qmk info -l to show the layouts too (qmk#10882)
  New command: qmk lint (qmk#10761)
  Updates to Talljoe's Keymaps (qmk#10115)
  [Keymap] bcat keymaps and userspace (qmk#10705)
  add dp60 indicator mode (qmk#8801)
  E85 backlight & LED indicator updates (qmk#10678)
  Add support for 4 IS31FL3731 devices (qmk#10860)
  [Keymap] add brandonschlack userspace and keymaps (qmk#10411)
  [Keymap] add ai03/polaris:mekberg (qmk#10508)
  CLI: Add `qmk clean` (qmk#10785)
  Adds support for XD84 Pro (qmk#9750)
  Freyr refactor (qmk#10833)
  KC60 refactor (qmk#10834)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants