-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NK65 eeprom compatibility with 128KB and 256KB #10804
Conversation
@tzarc could you take a look please?:) |
Wouldn't this be better to go into the core? If not now, then later, at least? |
yes it does, I mean I can add it no problem, just let me know if you care about the extra read cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll assume it's been tested on your end, the change itself looks fine (keeping in mind I'm not familiar with F303) and it's localised to the board in question.
I'd prefer to raise it as a separate PR for core, later, once a thorough look can be cast on it.
It has been tested yes.
More fine grain. If people agree on that I can file a separate PR shortly |
Issue has been filed: #10836 |
* NK65 define hack for 128kb 256kb versions of F303 * Updated to chibios define
* NK65 define hack for 128kb 256kb versions of F303 * Updated to chibios define
* upstream/master: (153 commits) [Keymap] add brandonschlack userspace and keymaps (qmk#10411) [Keymap] add ai03/polaris:mekberg (qmk#10508) CLI: Add `qmk clean` (qmk#10785) Adds support for XD84 Pro (qmk#9750) Freyr refactor (qmk#10833) KC60 refactor (qmk#10834) [Keyboard] Fixes for PloopyCo mouse and readmes (qmk#10841) Enable extrakeys, mousekeys for all VIA keymaps. (qmk#10740) Add OLED support for Riblee F411 (qmk#10778) NK65 eeprom compatibility with 128KB and 256KB (qmk#10804) Add support for Noxary Vulcan (qmk#10822) Enable media keys support for Canoe VIA keymap (qmk#10829) Phantom refactor (qmk#10805) `qmk info`: Add `--ascii` flag (qmk#10793) [Keymap] Corrected the dvorak layout for kinesis advantage (qmk#10808) [Keyboard] Fix keyboard matrix scan rate with F072 (qmk#10226) [Keyboard] nullbitsco/nibble Configurator rework (qmk#10814) [Keyboard] VIA Support: Exent 65% (qmk#10797) [Keyboard] Add keebsforall/freebird60 (qmk#10774) add 65_ansi_split_bs to default community layouts (qmk#10770) ...
Due to some manufacturing constrains, a large number of NK65s have been made (but not sold) with a F303CB chip.
After contacting ST the Application Engineer has informed me that CB and CC share the same die, but CB is validated to have working Flash up to 128KB. This means that in both versions of the chip, 256KB are addressable but not necessarily functioning.
This workaround asks for the size of the flash memory from the internal register. This means that it will auto adjust to 128KB or 256KB.
This saves adding a whole new chip class "F303xB" that chibios doesn't have, probably because the only difference is the flash size. Downside is that the every time there is an eeprom access an extra cycle is used to read that register. This is the reason I opted to not add it in core.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist