Add support for 8 buttons to mouse report #10807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the VUSB code should be updated as well. |
|
I did not realize that VUSB used it's own set of descriptors. But fixed. Same with nitpicks. |
fauxpark
requested changes
Oct 30, 2020
sigprof
requested changes
Nov 5, 2020
drashna
added
the
breaking_change
drashna
force-pushed
the
improve_mouse_reports
branch
from
8da464f to
b4a0a51
Compare
fauxpark
approved these changes
Nov 9, 2020
drashna
force-pushed
the
improve_mouse_reports
branch
from
b4a0a51 to
d7f6028
Compare
This includes support for 8 buttons in mousekeys. However, this does move the keys around due to the fact that the last mousekey keycode is already 0xFF, so any past that would not work with register_code and the like, breaking them for tap hold keys, encoders, and other features.
Because drashna red gud
drashna
force-pushed
the
improve_mouse_reports
branch
from
d7f6028 to
d233b12
Compare
tzarc
approved these changes
Jan 27, 2021
matthewdias
pushed a commit
to matthewdias/qmk_firmware
that referenced
this pull request
Mar 27, 2021
This reverts commit 99f3df2.
jiaxin96
pushed a commit
to Oh-My-Mechanical-Keyboard/qmk_firmware
that referenced
this pull request
Oct 18, 2023
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Add support for 8 buttons to mouse report This includes support for 8 buttons in mousekeys. However, this does move the keys around due to the fact that the last mousekey keycode is already 0xFF, so any past that would not work with register_code and the like, breaking them for tap hold keys, encoders, and other features. * Update mouse key docs * Add changes based on feedback * Fix VUSB report size comment Because drashna red gud * Fix typo in action.c * Fix IS_MOUSE_BUTTON check * Change start range for mousekeys so that the end is 0xFF properly * condense mousekeys check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes support for 8 buttons in mousekeys. However, this does move the keys around due to the fact that the last mousekey keycode is already 0xFF, so any past that would not work with register_code and the like, breaking them for tap hold keys, encoders, and other features.
Types of Changes
Checklist