Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shared EP on V-USB boards #11103

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 1, 2020

Description

Basically just a rename of the mouse/extra interface to shared, and implementing KEYBOARD_SHARED_EP.
Tested on Plaid-Pad, but a more thorough typing test might be useful.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Copy link
Member Author

I'm pretty confident now that this works properly - removing the delays from my sendstring macros, I don't see any dropped keypresses.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__((weak)) approval

Looks good, and compiles.

@fauxpark fauxpark merged commit aa0e33e into qmk:master Jan 11, 2021
@fauxpark fauxpark deleted the vusb-shared-ep branch January 11, 2021 08:46
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Feb 2, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants