Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ASkeyboard Sono1 #11114

Merged
merged 3 commits into from
Dec 22, 2020
Merged

add ASkeyboard Sono1 #11114

merged 3 commits into from
Dec 22, 2020

Conversation

DmNosachev
Copy link
Contributor

New keyboard: ASCII Corp ASkeyboard Sono1 with Sono2 numpad
QMK-conversion by directly connecting to the existing matrix

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team December 8, 2020 02:29
keyboards/handwired/sono1/rules.mk Show resolved Hide resolved
keyboards/handwired/sono1/sono1.c Outdated Show resolved Hide resolved
keyboards/handwired/sono1/sono1.c Outdated Show resolved Hide resolved
Co-authored-by: Ryan <fauxpark@gmail.com>
@DmNosachev DmNosachev requested a review from fauxpark December 15, 2020 10:00
@drashna drashna requested a review from a team December 17, 2020 06:15
@drashna drashna merged commit bf324c3 into qmk:master Dec 22, 2020
nblyumberg pushed a commit to nblyumberg/qmk_firmware that referenced this pull request Dec 31, 2020
* handwired/sono1

* readme: addition

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
* handwired/sono1

* readme: addition

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
@DmNosachev DmNosachev deleted the sono1 branch May 13, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants