Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused action_get_macro() usages in user keymaps & layouts #11165

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 9, 2020

Description

This is all the action_get_macro() functions that either define no macro handlers, or do but which are not referenced anywhere in the keymap as M() keycodes or in fn_actions. There are still a ton of keymaps to be converted over to process_record_user().

Also removes "the old way" macro documentation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 9, 2020 08:35
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Dec 9, 2020
@drashna drashna requested a review from a team December 9, 2020 19:03
@drashna drashna merged commit 415d683 into qmk:develop Jan 11, 2021
@fauxpark fauxpark deleted the unused-macro-cleanups branch January 11, 2021 09:34
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment documentation enhancement keymap optimization translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants